feat: Support obtaining client IP from CloudFront-Viewer-Address header #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey :) Yes, I'd prefer removing the feature flag to keep it simple ;) |
|
@imbolc Hi, thanks for the feedback. I have removed the feature flag. Technically, this is now a breaking change since the |
|
Published, thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for the crate!
This PR adds support for the
CloudFront-Viewer-Addressheader supported by AWS CloudFront.I put the feature behind a feature flag, since it could hardly be called a standard, but this could also be omitted if you prefer the simpler version without the feature flag.
Thanks!