Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARCH-2011 - Adding tests #8

Merged
merged 8 commits into from
Mar 20, 2024
Merged

ARCH-2011 - Adding tests #8

merged 8 commits into from
Mar 20, 2024

Conversation

danielle-casella-adams
Copy link
Contributor

@danielle-casella-adams danielle-casella-adams commented Mar 12, 2024

Summary of Changes

ARCH-2011 - Tests and refactor

  • De-typescript the action since it was not using typescript functionality
  • Change build from ncc to esbuild (to make it consistent with readme and other im-open actions)
  • Remove unused inputs and functionality (+semver:breaking)
  • Add new error-reason output to facilitate testing
  • Adding tests & supporting files
  • Update to node20

I tested out upgrading the report generator tool version to the latest 5.2.2 and the next patch version 4.8.13 but the summaries they produced omitted a number of metrics that other consumers (like process-code-coverage-summary) might be depending on. For the time being I'm going to keep it at 4.8.12.

- Adding tests, input files and expected output files
- Removing inputs that were not utilized (in im-orgs or public github)
  +semver:breaking
- Adding an error-reason output to facilitate testing
- Some refactoring/simplification of the code
@danielle-casella-adams danielle-casella-adams requested a review from a team as a code owner March 12, 2024 17:13
@danielle-casella-adams danielle-casella-adams force-pushed the adding-tests branch 12 times, most recently from 2d16656 to d9eecad Compare March 12, 2024 21:53
Copy link

Before this PR can be merged, the following item(s) should be addressed to comply with the action's Contributing Guidelines.

  • Please ensure the action has been recompiled by running the following command from the root of the repository:
    npm run build

@danielle-casella-adams danielle-casella-adams merged commit 4a07a93 into main Mar 20, 2024
5 checks passed
@danielle-casella-adams danielle-casella-adams deleted the adding-tests branch March 20, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants