Skip to content

Commit

Permalink
ARCH-2011 - Update to node20
Browse files Browse the repository at this point in the history
+semver:minor
  • Loading branch information
danielle-casella-adams committed Mar 7, 2024
1 parent a392602 commit b922d76
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 23 deletions.
2 changes: 1 addition & 1 deletion .github/actions/did-custom-action-code-change/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ outputs:
HAS_CHANGES:
description: 'Flag indicating whether changes were found in the code files or code folders.'
runs:
using: 'node16'
using: 'node20'
main: 'dist/index.js'
2 changes: 1 addition & 1 deletion .github/actions/update-action-version-in-file/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@ outputs:
description: 'The updated file content after replacements are made.'

runs:
using: 'node16'
using: 'node20'
main: 'dist/index.js'
12 changes: 6 additions & 6 deletions .github/workflows/reusable-build-and-review-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ on:
description: The version of node to build the action with.
required: false
type: string
default: '16.x'
default: '20.x'

jobs:
setup:
Expand All @@ -76,7 +76,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0

Expand Down Expand Up @@ -141,16 +141,16 @@ jobs:

- name: Checkout
if: env.HAS_CODE_CHANGES == 'true'
uses: actions/checkout@v3
uses: actions/checkout@v4

# -----------------------------------
# Check if action has been recompiled
# -----------------------------------
- name: If action has build step - Setup Node ${{ inputs.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
if: env.HAS_CODE_CHANGES == 'true' && env.HAS_BUILD_STEP == 'true'
with:
node-version: ${{ inputs.node-version }} # Default is 16.x
node-version: ${{ inputs.node-version }} # Default is 20.x

- name: If action has build step - Build the action
if: env.HAS_CODE_CHANGES == 'true' && env.HAS_BUILD_STEP == 'true'
Expand Down Expand Up @@ -194,7 +194,7 @@ jobs:
- name: Fail the workflow if there are any outstanding changes
if: env.HAS_CODE_CHANGES == 'true' && (env.NEEDS_BUILD_COMMIT == 'true' || env.NEEDS_README_COMMIT == 'true')
id: summary
uses: actions/github-script@v6
uses: actions/github-script@v7
with:
script: |
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/reusable-increment-version-on-merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
steps:
- name: Check if merge to default branch
id: merge
uses: actions/github-script@v6
uses: actions/github-script@v7
with:
script: |
const defaultBranch = '${{ inputs.default-branch }}';
Expand All @@ -60,7 +60,7 @@ jobs:
- name: Checkout
if: env.MERGE_TO_MAIN == 'true'
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: If PR is merged to ${{ inputs.default-branch }} - Check for code changes to the action source code
if: env.MERGE_TO_MAIN == 'true'
Expand All @@ -82,7 +82,7 @@ jobs:
- name: If PR is merged to ${{ inputs.default-branch }} & PR has source code changes - Checkout
if: env.MERGE_TO_MAIN == 'true' && steps.source-code.outputs.HAS_CHANGES == 'true'
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0

Expand Down
24 changes: 12 additions & 12 deletions .github/workflows/test-custom-actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: PR Source - ${{ env.PR_SOURCE }}
run: echo "PRs can come from a branch or a fork. This PR is from a ${{ env.PR_SOURCE }}."
Expand Down Expand Up @@ -74,11 +74,11 @@ jobs:
# -----------------------------------
# Check if action has been recompiled
# -----------------------------------
- name: Setup Node 16.x
uses: actions/setup-node@v3
- name: Setup Node 20.x
uses: actions/setup-node@v4
if: env.HAS_CHANGES == 'true'
with:
node-version: 16.x
node-version: 20.x

- name: Build the action
if: env.HAS_CHANGES == 'true'
Expand All @@ -101,7 +101,7 @@ jobs:
- name: Fail the workflow if the action needs to be recompiled
if: env.HAS_CHANGES == 'true' && env.NEEDS_BUILD_COMMIT == 'true'
id: summary
uses: actions/github-script@v6
uses: actions/github-script@v7
with:
script: |
Expand Down Expand Up @@ -165,7 +165,7 @@ jobs:

- name: Setup - Checkout
if: always() && env.HAS_CHANGES == 'true'
uses: actions/checkout@v3
uses: actions/checkout@v4

# -------------------------------------------
# FULL FILE PATH THAT MATCHES
Expand Down Expand Up @@ -345,7 +345,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: PR Source - ${{ env.PR_SOURCE }}
run: echo "PRs can come from a branch or a fork. This PR is from a ${{ env.PR_SOURCE }}."
Expand Down Expand Up @@ -378,11 +378,11 @@ jobs:
# -----------------------------------
# Check if action has been recompiled
# -----------------------------------
- name: Setup Node 16.x
uses: actions/setup-node@v3
- name: Setup Node 20.x
uses: actions/setup-node@v4
if: env.HAS_CHANGES == 'true'
with:
node-version: 16.x
node-version: 20.x

- name: Build the action
if: env.HAS_CHANGES == 'true'
Expand All @@ -405,7 +405,7 @@ jobs:
- name: Fail the workflow if the action needs to be recompiled
if: env.HAS_CHANGES == 'true' && env.NEEDS_BUILD_COMMIT == 'true'
id: summary
uses: actions/github-script@v6
uses: actions/github-script@v7
with:
script: |
Expand Down Expand Up @@ -459,7 +459,7 @@ jobs:

- name: Setup - Checkout
if: always() && env.HAS_CHANGES == 'true'
uses: actions/checkout@v3
uses: actions/checkout@v4

#--------------------------------------
# FILE HAS CHANGES
Expand Down

0 comments on commit b922d76

Please sign in to comment.