fixing-busy waiting loop #server session #3126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ghost
changed the title
|
Changing the README.md file doesn't fix the code because the README.md file is a documentation file, not the code itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR addresses the issue of busy-waiting in the session expiration task of the Server Session Pattern. Previously, the session expiration thread continuously checked for expired sessions without any pauses, which led to unnecessary CPU consumption.
Key improvements:
Replaced the busy-waiting loop with a Thread.sleep() mechanism, ensuring the thread pauses and consumes no CPU resources between checks.
Added graceful handling of thread interruptions for proper thread lifecycle management.
This change significantly reduces the overhead caused by constantly checking for session expiration, making the session management more efficient and resource-friendly.