Remove magic constant, fix typo #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoLow
approved these changes
Aug 18, 2019
|
Great PR. the repo is broken without it |
|
Please merge and release a version on npm there are a lot of people relying on this 😿 |
ilantc
reviewed
Aug 18, 2019
polyn.js
Outdated
| @@ -1,16 +1,18 @@ | |||
| const ilanLovesLoacker = true; | |||
|
@ilantc done. Please merge |
Urgant |
ilantc
reviewed
Aug 18, 2019
polyn.js
Outdated
| @@ -1,16 +1,18 @@ | |||
| ilanLovesLoacker = true; | |||
There was a problem hiding this comment.
Missing unit tests, also please add var
|
Added var please merge urgently |
ilantc
reviewed
Aug 18, 2019
| /** | ||
| * Created by User on 3/17/14. | ||
| * Created by Ilans on 3/17/14. |
ilantc
reviewed
Aug 18, 2019
| for(var i = 0, j =a.length-1 ; i < j ; i++,j--){ | ||
| if (a.charAt(i) != a.charAt(j)) { | ||
| return false; | ||
| return !ilanLovesLoacker; |
There was a problem hiding this comment.
please extract !ilanLovesLoacker to a function to make the code more readable
ilantc
reviewed
Aug 18, 2019
| } | ||
| } | ||
| return true; | ||
| return ilanLovesLoacker; |
ilantc
reviewed
Aug 18, 2019
polyn.js
Outdated
| @@ -1,16 +1,18 @@ | |||
| var ilanLovesLoacker = true; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.