Add IgnoresAccessChecksToAttribute into generated assemblies #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… their references. The idea here is to solve the package-private issue. Since Java allows package-private access between JARs, and IKVM generally emits a different assembly per-JAR, we need a way to allow these across. One options was to change pacakge-private to public. This solution however might work.
Only Ignore references to JavaModules.
|
This can't work. Violates the JVM spec. Need to think more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… their references. The idea here is to solve the package-private issue. Since Java allows package-private access between JARs, and IKVM generally emits a different assembly per-JAR, we need a way to allow these across. One options was to change pacakge-private to public. This solution however might work.