Add a raw argument to the iamc.tabulate()
#38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meksor
reviewed
Jan 11, 2024
There was a problem hiding this comment.
Hm, not sure about making the default different, my guess is that the dependants will rely on the current format so it is probably better to make raw=True the default or rename the argument to iamc_format and default to false.
Also, there seem to be misordered imports...
|
I'm a bit skeptical of having an argument Also, I don't think that there are any dependants yet anyway at the facade level, pyam will be the first. And I see a strong case for making the default such that it is like the format that people are used to, both for input to and return from ixmp4. |
meksor
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed today, this PR adds an argument
rawto theiamc.tabulate()endpoint - alternative suggestions for the name welcome...At the end of a series PRs, the iamc endpoints should take (
add(),remove()) and return (tabulate()) both the ixmp4-db-internal format (with columns type, step_year, step_datetime, step_category) or the standard IAMC format with columns year, time and/or subannual.This PR cleans up the datapoints-tets and adds the feature to correctly return the datapoints in standard IAMC format. In the interest of keeping this PR manageable, I did not add more changes.