Add profiling & benchmarks for Indexset
and Parameter
-- clean
#155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds profiling tests for
Parameter
s andIndexset
s. It also increases performance by avoiding thecopy.deepcopy()
calls when validating optimization data and adjusts the validation function accordingly.Unfortunately, #150 has fallen out of sync with
main
. When trying to do agit rebase
there, git wants to rebase all commits, which in this case means all 118 commits in the whole repository, creating lots of unnecessary conflicts.So instead of dealing with that, I looked at the largest files in our git history (thanks to stackoverflow) in a fresh clone and found that it doesn't contain the big parameterdata file that was committed by accident.
List of ten largest files in our git history right now
Which means: the branch was deleted and never merged, thus the file was never present and we don't need to invoke
git filter-repo
to clean up. All we need to do is open a new PR based onmain
and cherry-pick the commits we're interested in, which is what this PR does.Note
The two largest files come from the branch #112, which will likely not be merged anytime soon. It also contains the script with which these files were created, so we can already cut repo size quite significantly by going to that branch and removing these files (first try a new commit doing that, then checking files sizes in a fresh clone again, if that didn't work, re-work the commit that introduced the files | alternatively, delete this branch, but I'd like to keep it for now in case we want to revisit that topic).