-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include the GAMS version of the transport tutorial #108
Open
glatterf42
wants to merge
57
commits into
include/transport-tutorial-linopy
Choose a base branch
from
include/transport-tutorial-gams
base: include/transport-tutorial-linopy
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Include the GAMS version of the transport tutorial #108
glatterf42
wants to merge
57
commits into
include/transport-tutorial-linopy
from
include/transport-tutorial-gams
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Covers: * run__id, data, name, uniqueness of name together with run__id * Adapts tests since default order of columns changes
* Make Column generic enough for multiple parents * Introduce optimization.Parameter * Add tests for add_data * Enable remaining parameter tests (#86) * Enable remaining parameter tests * Include optimization parameter api layer (#89) * Bump several dependency versions * Let api/column handle both tables and parameters * Make api-layer tests pass * Include optimization parameter core layer (#90) * Enable parameter core layer and test it * Fix things after rebase * Ensure all intended changes survive the rebase * Adapt data validation function for parameters * Allow tests to pass again
* Exclude non-working one for now * Duplicate model file :(
This was referenced Aug 26, 2024
* Exclude resulting files from version control * Adapt code to make tests pass * Copy required code temporarily until location is finalized
9bf74bc
to
3c3b60b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially the same as #101, but with GAMS/gamsapi instead of linopy.
This PR is based on top of that branch, too, and actually adds only five commits. Two of those are the content of #107, so won't need to remain in here, either.
Hence: When reviewing/looking at the code, please focus on the new files in
tutorial/transport/
.Please note: there is no test yet, but the values resulting from running the tutorial are correct. I'll add tests soon.