Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum version of genno #514

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

glatterf42
Copy link
Member

@glatterf42 glatterf42 commented Jan 17, 2024

As noted by @awais307, we should bump the minimum required version of genno to the one that introduces genno.operator.

How to review

  • Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • [ ] Add or expand tests; coverage checks both ✅ Just bumping dependency
  • [ ] Add, expand, or update documentation. Just bumping dependency
  • [ ] Update release notes. Just bumping dependency

@glatterf42 glatterf42 added the enh New features & functionality label Jan 17, 2024
@glatterf42 glatterf42 added this to the 3.9 milestone Jan 17, 2024
@glatterf42 glatterf42 self-assigned this Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (49ec67d) 98.9% compared to head (aa75739) 98.2%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #514     +/-   ##
=======================================
- Coverage   98.9%   98.2%   -0.8%     
=======================================
  Files         44      44             
  Lines       4795    4795             
=======================================
- Hits        4744    4709     -35     
- Misses        51      86     +35     

see 3 files with indirect coverage changes

@khaeru
Copy link
Member

khaeru commented Jan 17, 2024

This should also go in the release notes. For examples, see:

- Adjust to genno 1.12 and set this as the minimum required version for :mod:`ixmp.reporting <ixmp.report>` (:pull:`451`).

ixmp/RELEASE_NOTES.rst

Lines 91 to 94 in 49ec67d

- Minimum requirements are increased for dependencies (:pull:`435`):
- Python 3.7 or greater. Python 3.6 reached end-of-life on 2021-12-31.
- Pandas 1.2 (2020-12-26) or greater, the oldest version with a minimum Python version of 3.7.

@glatterf42
Copy link
Member Author

Merging this since the coverage is not affected, codecov just didn't register the reports correctly.

@glatterf42 glatterf42 merged commit 8a2aa91 into iiasa:main Jan 17, 2024
20 of 21 checks passed
@glatterf42 glatterf42 deleted the update/genno-version branch January 17, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh New features & functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants