Fix linter issues

Signed-off-by: Ivan Sim <[email protected]>
ihcsim · May 18, 2024 · 140355c · 140355c
1 parent 79579ca
commit 140355c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/cmd/root.go b/cmd/root.go
@@ -65,7 +65,7 @@ func run(ctx context.Context) error {
 
 	go func() {
 		s := http.NewServeMux()
-		s.HandleFunc(fmt.Sprintf("%s", pprofPath), pprof.Index)
+		s.HandleFunc(pprofPath, pprof.Index)
 		if err := http.ListenAndServe(fmt.Sprintf(":%d", pprofPort), s); err != nil {
 			log.Warn().Err(err).Msg("failed to start pprof server")
 		}

diff --git a/pkg/drivers/gpu/driver.go b/pkg/drivers/gpu/driver.go
@@ -203,8 +203,9 @@ func (d *driver) allocateGPU(
 
 	go func() {
 		<-releaseClaim
+		//nolint:staticcheck
 		if err := d.gpu.removeAllocatedClaim(claimUID); err != nil {
-			// log errors here
+			//@TODO log errors here
 		}
 	}()
 
@@ -272,8 +273,7 @@ func getSelectedNode(claim *resourcev1alpha2.ResourceClaim) string {
 }
 
 func (d *driver) deallocateGPU(ctx context.Context, claimUID string, gpu allocationv1alpha1.AllocatedGPU) error {
-	d.gpu.removeAllocatedClaim(claimUID)
-	return nil
+	return d.gpu.removeAllocatedClaim(claimUID)
 }
 
 // see https://pkg.go.dev/k8s.io/dynamic-resource-allocation/controller#Driver