lazy_static replaced by std::sync::OnceLock
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. `String` was changed to `Box<str>` to reduce memory usage. 2. The helper functions in `constants.rs` now return a reference instead of a copy which reduces memory usage and improves performance
|
This is great, but there's some conflicts with some other PRs I just merged, can you update this branch? |
|
💯 |
igorlira
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lazy_staticis no longer needed sinceRust 1.70.0Edit
Changes have been made HERE to reduce memory usage and improve performance.
Stringwas changed toBox<str>to reduce memory usage.constants.rsnow return a reference instead of a copy which reduces memory usage and improves performance.