update self check (truth and false) on every loop iteration

also fix property value and property name detection
ifedapoolarewaju · Feb 8, 2019 · b69418d · b69418d
1 parent 1e2da7a
commit b69418d
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+### 0.1.3 / 2019-02-07 ###
+
+* update `self` check (truth and false) on every loop iteration
+* fix property value and property name detection
+
 ### 0.1.2 / 2019-02-07 ###
 
 * Add support for triggers

diff --git a/dist/no.min.js b/dist/no.min.js
diff --git a/example/style.css b/example/style.css
@@ -51,7 +51,7 @@ input[type=text] {
 
 .sidemenu {
   position: absolute;
-  // minus height of header;
+  /* minus height of header; */
   height: calc(100% - 56px);
   top: 56px;
   left: -360px;

diff --git a/no.js b/no.js
@@ -67,14 +67,19 @@
           var target = el;
           isSelf = true;
         } else {
+          isSelf = false;
           var target = paramValues[0];
         }
 
+        var propertyName = propertyOrEventType;
         var propertyValue;
-        if (action !== 'remove' || action !== 'reset') {
-          var index = this_._getPropertyValueIndex(propertyOrEventType, isSelf)
+        if (action !== 'reset') {
+          var index = this_._getPropertyValueIndex(propertyOrEventType, isSelf);
           // join space containing values that might have been split.
-          propertyValue = paramValues.splice(index).join(' ')
+          propertyValue = paramValues.slice(index).join(' ');
+          if (propertyOrEventType === 'attribute') {
+            propertyName = paramValues[index - 1];
+          }
         }
 
         var options = {
@@ -83,7 +88,7 @@
           sourceElement: el,
           propertyOrEventType: propertyOrEventType,
           propertyValue: propertyValue,
-          propertyName: propertyOrEventType === 'attribute' ? paramValues[1] : propertyOrEventType
+          propertyName: propertyName
         }
 
         el.addEventListener(eventType, function(e) {
@@ -141,6 +146,8 @@
   }
 
   NoJS.prototype._getPropertyValueIndex = function (propertyOrEventType, isSelf) {
+    // if props type is attribute, the signature takes the form
+    // on-[evtType]-[action]-attribute = "target propertyName propertyValue"
     var index = propertyOrEventType === 'attribute' ? 2 : 1;
     return isSelf ? index - 1 : index;
   }

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "nojs",
-  "version": "0.1.2",
+  "version": "0.1.3",
   "description": "Library that helps minimize js you have to write",
   "main": "no.js",
   "scripts": {