Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. tags grammar fixes #965

Merged
merged 12 commits into from
Feb 23, 2025
2 changes: 1 addition & 1 deletion chapter_codecs.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ to reach the chapter we switch to **MUST** be executed, until that chapter is th
The enter commands of that chapter **MUST** be executed as well.

When the last Chapter finished playing, i.e., its `ChapterTimeEnd` has been reached,
the `Matroska Player` **MUST** execute its leaved commands, then the leave commands of it's `Parent Chapter`,
the `Matroska Player` **MUST** execute its leaved commands, then the leave commands of its `Parent Chapter`,
until the parent of the chapter is the Edition.


Expand Down
4 changes: 2 additions & 2 deletions codec_specs.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ Documentation of the associated normative and informative references for the cod

### Superseded By

When a `Superseded By` is set, the specified `CodecID` value **MUST** be used instead of the `CodecID` it's defined for.
When a `Superseded By` is set, the specified `CodecID` value **MUST** be used instead of the `CodecID` it is defined for.

Files **MAY** exist with the superseded `CodecID` and **MAY** be supported by Matroska Players.

Expand Down Expand Up @@ -466,7 +466,7 @@ Description: VP9 is an open and royalty free video compression format developed
Codec BlockAdditions: A single-channel encoding of an alpha channel **MAY** be stored in `BlockAdditions`. The `BlockAddID` of the `BlockMore` containing these data **MUST** be 1.

Initialization: The `CodecPrivate` **SHOULD** contain a list of specific VP9 codec features as described in the "VP9 Codec Feature Metadata" section of [@!WebMContainer].
This piece of data helps to select a decoder on playback, but as many muxers don't provide the `CodecPrivate` for "V_VP9" it's not a hard requirement.
This piece of data helps to select a decoder on playback, but as many muxers don't provide the `CodecPrivate` for "V_VP9" it is not a hard requirement.
It is possible for the decoder to reconstruct the "VP9 Codec Feature Metadata" from the first frame in case the `CodecPrivate` is not present.

Note that the format differs from the `VPCodecConfigurationRecord` structure, as defined in [@VP-ISOBMFF].
Expand Down
2 changes: 1 addition & 1 deletion index_tags.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ in a Matroska `Segment`. It can tag a whole `Segment`, separate `Tracks` element

Some details about tagging are already present in [@!RFC9559, section 24].

While the Matroska tagging framework allows anyone to create their own custom tags, it's important to have a common
While the Matroska tagging framework allows anyone to create their own custom tags, it is important to have a common
set of values for interoperability. This document defines a set of common tag names used in Matroska.

# Notation and Conventions
Expand Down
2 changes: 1 addition & 1 deletion matroska5_body.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ definition:
: Indicates what type of content the `ChapterAtom` contains and might be skipped.
It can be used to automatically skip content based on the type.
If a `ChapterAtom` is inside a `ChapterAtom` that has a `ChapterSkipType` set, it
**MUST NOT** have a `ChapterSkipType` or have a `ChapterSkipType` with the same value as it's parent `ChapterAtom`.
**MUST NOT** have a `ChapterSkipType` or have a `ChapterSkipType` with the same value as its parent `ChapterAtom`.
If the `ChapterAtom` doesn't contain a `ChapterTimeEnd`, the value of the `ChapterSkipType` is only valid
until the next `ChapterAtom` with a `ChapterSkipType` value or the end of the file.

Expand Down
10 changes: 5 additions & 5 deletions matroska_tags.xml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ or for video's audio track you might use "English 5.1" This is akin to the "TIT2
This is akin to the "TIT3" tag in [@!ID3v2.3] when the `TargetTypeValue` is 30 (TRACK).</description>
</tag>
<tag name="URL" class="Nested Information" type="UTF-8">
<description lang="en">URL corresponding to the tag it's included in, using the format defined in [@!RFC3986].</description>
<description lang="en">URL corresponding to the tag it is included in, using the format defined in [@!RFC3986].</description>
</tag>
<tag name="SORT_WITH" class="Nested Information" type="UTF-8">
<description lang="en">A child `SimpleTag` element to indicate what alternative value the parent `SimpleTag` element can have
Expand All @@ -71,18 +71,18 @@ Or "Marley Bob" and "Marley Robert Nesta" (no comma needed).</description>
It **SHOULD** be a child of the following tags: "ARTIST", "LEAD_PERFORMER", or "ACCOMPANIMENT".</description>
</tag>
<tag name="EMAIL" class="Nested Information" type="UTF-8">
<description lang="en">Email corresponding to the tag it's included in, using the "Addr-Spec" format defined in [@!RFC5322, section 3.4.1].</description>
<description lang="en">Email corresponding to the tag it is included in, using the "Addr-Spec" format defined in [@!RFC5322, section 3.4.1].</description>
</tag>
<tag name="ADDRESS" class="Nested Information" type="UTF-8">
<description lang="en">The physical address of the entity. The address **SHOULD** include a country code using the Country Code format defined in (#country-code-tags-formatting).
It can be useful for a recording label.</description>
</tag>
<tag name="FAX" class="Nested Information" type="UTF-8">
<description lang="en">The fax number corresponding to the tag it's included in.
<description lang="en">The fax number corresponding to the tag it is included in.
It can be useful for a recording label.</description>
</tag>
<tag name="PHONE" class="Nested Information" type="UTF-8">
<description lang="en">The phone number corresponding to the tag it's included in.
<description lang="en">The phone number corresponding to the tag it is included in.
It can be useful for a recording label.</description>
</tag>
<tag name="ARTIST" class="Entities" type="UTF-8">
Expand Down Expand Up @@ -230,7 +230,7 @@ The format follows the "TCON" tag in [@!ID3v2.3] when the `TargetTypeValue` is 3
<description lang="en">Describes the period that the piece is from or about. For example, "Renaissance".</description>
</tag>
<tag name="LAW_RATING" class="Search and Classification" type="UTF-8">
<description lang="en">Depending on the "COUNTRY" it's the format of the rating of a movie (P, R, X in the USA,
<description lang="en">Depending on the "COUNTRY" it is the format of the rating of a movie (P, R, X in the USA,
an age in other countries or a URI defining a logo).</description>
</tag>
<tag name="DATE_RELEASED" class="Temporal Information" type="UTF-8">
Expand Down
2 changes: 1 addition & 1 deletion menu.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ audio only files, a keyboard shortcut or button panel could be used for menus.
But in that case, the hotspot will have to be associated with a name to display.

This highlight is sent from the Control Track to the `Matroska Player`. Then the
`Matroska Player` has to handle that highlight until it's deactivated; see (#playback-features).
`Matroska Player` has to handle that highlight until it is deactivated; see (#playback-features).

The highlight contains a UID of the action, a displayable name (UTF-8), an associated
key (list of keys to be defined, probably up/down/left/right/select), a screen position/range
Expand Down
22 changes: 11 additions & 11 deletions tagging.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,13 @@ all tags **SHOULD** be strict. Our recommendations are in between.

Advanced-users application might let you put any tag in your file. But for the rest of
the applications, they usually give you a basic list of tags you can use. Both have their
needs. But it's usually a bad idea to use custom/exotic tags because you will probably
needs, but it's usually a bad idea to use custom or exotic tags because you will probably
be the only person to use this information even though everyone else could benefit from it.
So hopefully, when someone wants to put information in one's file, they will find an
official one that fits their need and hopefully use it. If it's not in the list, this person
can try get a new tag in the Matroska Tags Names registry ((#matroska-tags-names-registry)).
can try to add a new tag in the Matroska Tags Names registry ((#matroska-tags-names-registry)).
This registry is not meant to have every possible information in a file.
Matroska files are not meant the become a whole database of people who made
Matroska files are not meant to become a whole database of people who made
costumes for a film. A website would be better for that. It's hard to define what should
be in and what doesn't make sense in a file; thus, each demand needs to balance if it
makes sense to be carried over in a file for storage and/or sharing or if it doesn't belong there.
Expand Down Expand Up @@ -113,7 +113,7 @@ The "." separator represents the boundary between the integer value and the deci
If the string doesn't contain the "." separator, the value is an integer value.
Thousandths separators **SHOULD NOT** be used.

To display it differently for another local, applications **SHOULD** support auto
To display it differently for another locale, applications **SHOULD** support auto
replacement on display.

#### Country Code Tags Formatting
Expand Down Expand Up @@ -185,7 +185,7 @@ There are three organizational tags defined in (#organization-information):

- PART_OFFSET

These tags allow specifying the ordering of some tags within a another group of tags.
These tags allow specifying the ordering of some tags within another group of tags.

For example if you have an album with 10 tracks and you want to tag the second track from it.
You set "TOTAL_PARTS" to "10" at `TargetTypeValue` 50 (ALBUM). It means the "ALBUM" contains 10 lower parts.
Expand All @@ -205,7 +205,7 @@ and "PART_NUMBER" elements match the same levels.

Here is an example of an audio record with 2 tracks in a single file, corresponding to [@?DaFunk].
There is one `Tag` element for the record, and one `Tag` element per track on the record.
Each track being identified by a chapter.
Each track is identified by a chapter.

The `Tag` for the record:

Expand Down Expand Up @@ -396,7 +396,7 @@ This corresponds to this layout of EBML elements:
## Multiple Targets UID

A `Tag` element has a single `Targets` element with a single `TargetTypeValue` element.
But it can contain various `TagTrackUID`, `TagEditionUID`, `TagChapterUID` and `TagAttachmentUID` elements.
But the `Targets` element can contain various `TagTrackUID`, `TagEditionUID`, `TagChapterUID` and `TagAttachmentUID` elements.

When multiple values are found using the same Tag UID element (e.g., `TagTrackUID`)
a logical OR is applied on these elements.
Expand Down Expand Up @@ -470,15 +470,15 @@ This corresponds to this layout of EBML elements:
</Tags>
```

Some combination of different Tag UID elements are not possible.
Some combinations of different Tag UID elements are not possible.

A `TagChapterUID` and `TagAttachmentUID` can't be mixed because there is no overlap
with a Chapter and an Attachment that would make sense.
An attachment apply to the whole segment and can be tied to tracks,
An attachment applies to the whole segment and can be tied to tracks,
via `\Segment\Tracks\TrackEntry\AttachmentLink` as defined in [@!RFC9559, section 5.1.4.1.24], but not chapters.

Mixing `TagEditionUID` and `TagChapterUID` elements has also no use because each Chapter UIDs
would need to be in one of the Chapter Edition UIDs.
Mixing `TagEditionUID` and `TagChapterUID` elements is also not useful because each Chapter UID
would need to be in one of the Chapter Edition UID.
That would be the same as not using the list of `TagEditionUID` at all.

The following table shows the allowed combinations between lists of Tag UID elements:
Expand Down