minor updates

ieee-vgtc · Nov 27, 2024 · 8622e85 · 8622e85
1 parent fb35dd6
commit 8622e85
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 7 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -277,6 +277,7 @@ GEM
 PLATFORMS
   arm64-darwin-20
   universal-darwin-23
+  universal-darwin-24
   x86_64-linux
 
 DEPENDENCIES

diff --git a/_data/navigation.yml b/_data/navigation.yml
@@ -536,9 +536,9 @@ menu:
       #       #            heading_url: "/"
             columns:
               - links:
-                  - text: "2025 in Vienna, Austria"
-                    description: ""
-                    url: "/year/2025/blog/vis-25-in-vienna"
+                  # - text: "2025 in Vienna, Austria"
+                  #   description: ""
+                  #   url: "/year/2025/blog/vis-25-in-vienna"
                   - text: "How to Host IEEE VIS"
                     description: "Guidelines to bid for a future location of IEEE VIS"
                     url: "/governance/bids"

diff --git a/_includes/navigation.html b/_includes/navigation.html
@@ -17,11 +17,23 @@
             {% assign is_active_class = 'menu_item--is-active' %}
             {% endif %}
 
-            <button
+
+            <!-- This implementation of menu items has some issues (e.g. not highlighting on hover, not spanning full width on mobile) in comparison to other menu items. The implementation after this fixes those issues.-->
+            <!-- <button
                 class="menu_item {{is_active_class}} font-display text-lg md:text-base lg:text-lg px-8 md:px-2 lg:px-4 mx-0 lg:mx-2 py-4 md:py-6 border-b-2 border-primary-200 md:border-none"
-                tabindex="0" role="menuitem">
-                <a class="nav-text-link" href="{{ site.data.navigation.blog.url }}">{{ site.data.navigation.blog.text }}</a>
-            </button>
+                tabindex="0" 
+                role="menuitem"
+                >
+                <a class="nav-text-link" href="{{ site.data.navigation.blog.url }}">
+                    {{ site.data.navigation.blog.text }}
+                </a>
+            </button> -->
+
+
+            <a class="menu_item {{is_active_class}} font-display text-lg md:text-base lg:text-lg px-8 md:px-2 lg:px-4 mx-0 lg:mx-2 py-4 md:py-6 border-b-2 border-primary-200 md:border-none"
+                href="{{ site.data.navigation.blog.url }}">
+                {{ site.data.navigation.blog.text }}
+            </a>
 
             {% endif %}