Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore errors when completing #39

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

jeroendehaas
Copy link
Contributor

@jeroendehaas jeroendehaas commented Jan 7, 2023

Ignore evaluation errors during completion at point.

Should fix #36 and #27

@jeroendehaas jeroendehaas force-pushed the fix-completion-error branch 2 times, most recently from e53de49 to ba80dd7 Compare January 9, 2023 18:12
@jeroendehaas
Copy link
Contributor Author

I noticed a similar pattern in the completion functions for the REPL and prover. Patched those as well.

@kaelte
Copy link

kaelte commented Dec 19, 2024

When will this PR be approved and merged?
It has been open for almost 2 years and the issue #36 still makes programming Idris with Emacs hard.

Copy link

@kaelte kaelte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works find, focus stays in code buffer
Tested with

NixOS 24.11
GNU Emacs 29.4 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.18.2, Xaw3d scroll bars)
Doom

@gallais gallais merged commit 5b45136 into idris-community:main Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

*idris2-notes* buffer keeps stealing focus when there's an error if company-mode is enabled
3 participants