Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Added] Sort by tracked achievements #37

Merged
merged 2 commits into from
Nov 13, 2020
Merged

[Added] Sort by tracked achievements #37

merged 2 commits into from
Nov 13, 2020

Conversation

JanGalek
Copy link
Collaborator

This resolving #18

  • Added: option to turn on/off this feature (false default)
  • Added: sort tracked achievements up of show list

@JanGalek JanGalek force-pushed the sort-by-tracked branch 2 times, most recently from 4772ea6 to 3c5b9d8 Compare October 30, 2020 11:25
@JanGalek
[Added] Sort by tracked achievements
fb5658e 
Short-cut getTrackedAchievements
@JanGalek JanGalek requested a review from idiomatic October 30, 2020 11:38
@JanGalek
Copy link
Collaborator Author

@idiomatic I'm not sure if default should be true or false :)

@JanGalek
Copy link
Collaborator Author

JanGalek commented Nov 5, 2020

Sorry for delay, I have much work (at work) :)

@JanGalek JanGalek requested a review from idiomatic November 13, 2020 01:20
@idiomatic idiomatic merged commit 04222d7 into idiomatic:master Nov 13, 2020
@idiomatic
Copy link
Owner

idiomatic commented Nov 13, 2020 •
edited
Loading

Should also add a note to the changelog for each feature.

@JanGalek
Copy link
Collaborator Author

Yes, I'll send PR for it.

JanGalek added a commit that referenced this pull request Nov 19, 2020
@JanGalek
Update CHANGELOG.md
c5f3f97 
Changelog for #37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idiomatic idiomatic idiomatic approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JanGalek @idiomatic