Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: persisted messaging #204

Merged

Conversation

ibrizsabin
Copy link
Collaborator

@ibrizsabin ibrizsabin commented Nov 29, 2023

Description:

Commit Message

feat: persisted messaging

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #204 (86678b6) into development/177-xcall-future-proof-messaging (78c8955) will decrease coverage by 3.37%.
The diff coverage is 16.66%.

Additional details and impacted files

Impacted file tree graph

@@                                Coverage Diff                                 @@
##             development/177-xcall-future-proof-messaging     #204      +/-   ##
==================================================================================
- Coverage                                           70.18%   66.81%   -3.37%     
  Complexity                                             36       36              
==================================================================================
  Files                                                  34       40       +6     
  Lines                                                1831     2070     +239     
  Branches                                               10       10              
==================================================================================
+ Hits                                                 1285     1383      +98     
- Misses                                                540      681     +141     
  Partials                                                6        6              
Flag Coverage Δ
solidity 81.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
contracts/cosmwasm-vm/cw-xcall/src/execute_call.rs 78.82% <100.00%> (+1.04%) ⬆️
...ontracts/cosmwasm-vm/cw-xcall/src/types/request.rs 76.56% <100.00%> (+0.14%) ⬆️
...acts/cosmwasm-vm/cw-xcall/src/send_call_message.rs 95.93% <0.00%> (-1.29%) ⬇️
...s/cosmwasm-vm/cw-xcall-lib/src/message/envelope.rs 15.55% <0.00%> (ø)
...s/cosmwasm-vm/cw-xcall-lib/src/message/msg_type.rs 45.00% <0.00%> (ø)
...tracts/cosmwasm-vm/cw-xcall-lib/src/message/mod.rs 48.00% <0.00%> (ø)
...cw-xcall-lib/src/message/call_message_persisted.rs 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

@ibrizsabin ibrizsabin self-assigned this Nov 29, 2023
@pragyanshrestha-ibriz pragyanshrestha-ibriz added the iBriz iBriz Filter label Nov 30, 2023
Base automatically changed from feat/multi-message-rust to development/177-xcall-future-proof-messaging December 1, 2023 11:59
@ibrizsabin ibrizsabin marked this pull request as ready for review December 4, 2023 04:32
@ibrizsabin ibrizsabin linked an issue Dec 4, 2023 that may be closed by this pull request
Copy link
Collaborator

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ibrizsabin ibrizsabin merged commit 19568ed into development/177-xcall-future-proof-messaging Dec 14, 2023
@ibrizsabin ibrizsabin deleted the feat/persisted-messaging branch December 14, 2023 04:11
bishalbikram pushed a commit that referenced this pull request Oct 2, 2024
* feat: Add message types to xCall

* feat: add multi message

* fix: fix test

* refactor: csresponse to scresult

* refactor: csmessage type

* docs: Add new message strucute to xCall design doc

* refactor: rename result

* fix: fix test

* chore: cleanup

* test: add test for envelope encoding

* test: add envelope encoding test

* chore: fix lint

* feat: Add message types to xCall

* fix: remove should persist

* fix: remove duplicate merge

* feat: add persisted msg struct

* fix: encode length

* test: add persisted message tests

* chore: pass build

* fix: fix encoding test

* fix: remove msg type

* test: fix tests

* fix: Revert change of rollback db name

Break out db paths into static String variables

* Update docs/adr/xcall.md

Co-authored-by: AntonAndell <[email protected]>

* chore: pass build

* chore: pass build

* fix: persisted encoding

* fix: err if retry allowed

* chore: pass build

---------

Co-authored-by: AntonAndell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature iBriz iBriz Filter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rust: Implement Persistent message
3 participants