-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: persisted messaging #204
Merged
ibrizsabin
merged 34 commits into
development/177-xcall-future-proof-messaging
from
feat/persisted-messaging
Dec 14, 2023
Merged
feat: persisted messaging #204
ibrizsabin
merged 34 commits into
development/177-xcall-future-proof-messaging
from
feat/persisted-messaging
Dec 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject/xCall into feat/persisted-messaging
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development/177-xcall-future-proof-messaging #204 +/- ##
==================================================================================
- Coverage 70.18% 66.81% -3.37%
Complexity 36 36
==================================================================================
Files 34 40 +6
Lines 1831 2070 +239
Branches 10 10
==================================================================================
+ Hits 1285 1383 +98
- Misses 540 681 +141
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Break out db paths into static String variables
…-project/xCall into feat/multi-message-rust
Co-authored-by: AntonAndell <[email protected]>
Base automatically changed from
feat/multi-message-rust
to
development/177-xcall-future-proof-messaging
December 1, 2023 11:59
AntonAndell
requested changes
Dec 6, 2023
contracts/cosmwasm-vm/cw-xcall-lib/src/message/call_message_persisted.rs
Outdated
Show resolved
Hide resolved
AntonAndell
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
bishalbikram
pushed a commit
that referenced
this pull request
Oct 2, 2024
* feat: Add message types to xCall * feat: add multi message * fix: fix test * refactor: csresponse to scresult * refactor: csmessage type * docs: Add new message strucute to xCall design doc * refactor: rename result * fix: fix test * chore: cleanup * test: add test for envelope encoding * test: add envelope encoding test * chore: fix lint * feat: Add message types to xCall * fix: remove should persist * fix: remove duplicate merge * feat: add persisted msg struct * fix: encode length * test: add persisted message tests * chore: pass build * fix: fix encoding test * fix: remove msg type * test: fix tests * fix: Revert change of rollback db name Break out db paths into static String variables * Update docs/adr/xcall.md Co-authored-by: AntonAndell <[email protected]> * chore: pass build * chore: pass build * fix: persisted encoding * fix: err if retry allowed * chore: pass build --------- Co-authored-by: AntonAndell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Commit Message
see the guidelines for commit messages.
Changelog Entry
Checklist: