Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include <stdbool.h> header for C #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Include <stdbool.h> header for C #41

wants to merge 1 commit into from

Conversation

nbeams
Copy link
Contributor

@nbeams nbeams commented Feb 17, 2025

Includes the stdbool.h header for C users. This is necessary due to the addition of two functions with bool return type in magma_z.h in 1541e88. These routines are intended to be part of the public interface, so they need to stay in the header, despite only being used in one place internally.

Closes #38.

@nbeams nbeams added the bugfix Fixes a bug label Feb 17, 2025
Copy link
Contributor

@mgates3 mgates3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, though the #ifndef __cplusplus guard is unnecessary as stdbool.h has a guard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undeclared bool type in magma header file
2 participants