Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Committing changes related to program service join and invite role #438

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

Azher2Ali
Copy link
Contributor

@Azher2Ali Azher2Ali commented Mar 14, 2024

Issue:- When following the invite user and join program flow, using the HTTP endpoints, the role is not captured/returned. The user details in the program users list report the user role as null. (#432)

Solution- By adding a DEFAULT enum value at 0 position into User Role Value under protocol file. This DEFAULT value will only be used as placeholder and will never be used for any Role Type.

Copy link
Member

@joneubank joneubank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing a protobuff in this way carries some risk. Specifically any existing server that doesnt use the updated proto file will be interpretting UserRole enum of 1 as ADMIN while the server believes that is COLLABORATOR, this could cause real errors. Additionally, we don't want to have a role of DEFAULT. If this is fixing our problem its only because our converter is not handlign the default case, not because we need a role called DEFAULT.

@Azher2Ali Azher2Ali changed the title Committing changes related to program service join and invite role is… Committing changes related to program service join and invite role Mar 19, 2024
@Azher2Ali Azher2Ali requested a review from joneubank April 16, 2024 19:17
@Azher2Ali
Copy link
Contributor Author

Azher2Ali commented Apr 16, 2024

In regards to changes related to enum value returning as empty at the 0th position (COLLABORATOR) in the proto enum.Therefore, moving COLLABORATOR from 0th position to 5th position without affecting other existing values within the enum, adding a DEFAULT value at the 0th position.

@Azher2Ali Azher2Ali merged commit c8f6cbd into develop Apr 16, 2024
2 checks passed
@Azher2Ali Azher2Ali deleted the fix/programInviteRole branch April 16, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants