Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Committing changes related to creating data center table and entity and refactor program entity #421

Merged
merged 18 commits into from
Sep 27, 2023

Conversation

Azher2Ali
Copy link
Contributor

@Azher2Ali Azher2Ali commented Sep 12, 2023

Committing changes related to creating data center table and entity and refactor program entity

@Azher2Ali Azher2Ali changed the title Committing changes related to creating data center table and entity a… Committing changes related to creating data center table and entity and refactor program entity Sep 12, 2023
@Azher2Ali Azher2Ali requested a review from joneubank September 12, 2023 18:07
@joneubank joneubank requested a review from leoraba September 12, 2023 18:33
leoraba
leoraba previously approved these changes Sep 14, 2023
Copy link

@leoraba leoraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@Azher2Ali Azher2Ali requested review from leoraba and joneubank and removed request for joneubank and leoraba September 25, 2023 15:56
@Azher2Ali
Copy link
Contributor Author

The changes which were requested have been resolved in this PR and the following PR #422

leoraba
leoraba previously approved these changes Sep 25, 2023
Copy link
Member

@joneubank joneubank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@joneubank joneubank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placeholder values changes.

src/main/resources/flyway/sql/V17__create_data_center.sql Outdated Show resolved Hide resolved
Updating the query as requested by replacing all the URLs with https://example.com/ and email by @example.com
@Azher2Ali Azher2Ali requested a review from joneubank September 26, 2023 23:10
Copy link
Member

@joneubank joneubank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Azher2Ali Azher2Ali merged commit a527cfe into develop Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants