Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argo data submission [email protected] #97

Merged
merged 5 commits into from
Mar 12, 2024
Merged

Argo data submission [email protected] #97

merged 5 commits into from
Mar 12, 2024

Conversation

edsu7
Copy link
Contributor

@edsu7 edsu7 commented Mar 11, 2024

Addressing:
#96

To test:

  • with skipped tests
cd argo-data-submission/argo-data-submission-wf/tests

nextflow run ../../main.nf \
-profile docker,rdpc_qa \
-params-file local-test-job-7-InputCramJson.json \
--api_token ${API_TOKEN} \
--skip_duplicate_check true \
--ref_genome_fa ../../test_data/tiny-grch38-chr11-530001-537000.fa.gz \
--score_cpus 1 --score_mem 2 \
--skipping_tests 'c681,c683'
  • without
cd argo-data-submission/argo-data-submission-wf/tests

nextflow run ../../main.nf \
-profile docker,rdpc_qa \
-params-file local-test-job-7-InputCramJson.json \
--api_token ${API_TOKEN} \
--skip_duplicate_check true \
--ref_genome_fa ../../test_data/tiny-grch38-chr11-530001-537000.fa.gz \
--score_cpus 1 --score_mem 2

Running the follow on old version 1.1.0 should result in the following

No such file: argo-data-submission-wf/tests/NO_FILE4

New version should complete without issue.

@edsu7 edsu7 requested a review from guanqiaofeng March 11, 2024 15:35
@edsu7 edsu7 self-assigned this Mar 11, 2024
@guanqiaofeng
Copy link

Tested "with skipped tests" and "without" under [email protected] and main environment.

Got expected behaviour as described (success in [email protected]; and No such file: argo-data-submission-wf/tests/NO_FILE4 in main)

Copy link

@guanqiaofeng guanqiaofeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

read_group_info_tsv=file(og_read_group_info_tsv)
file_info_tsv=file(og_file_info_tsv)
experiment_info_tsv=payloadJsonToTsvs.out.experiment_tsv
read_group_info_tsv=payloadJsonToTsvs.out.read_group_tsv

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

@edsu7 edsu7 merged commit 5c5a3d1 into main Mar 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants