Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argo data submission [email protected] #93

Closed
wants to merge 3 commits into from
Closed

Conversation

edsu7
Copy link
Contributor

@edsu7 edsu7 commented Nov 30, 2023

Addressing the following items:

### Test QA
nextflow run ../main.nf -params-file local-test-job-5-InputBam.json --skip_duplicate_check -profile rdpc_qa,docker --score_mem 4 --score_cpus 4 --api_token ${QA_TOKEN}

### Test prod
nextflow run ../main.nf \
--skip_duplicate_check \
-profile rdpc,docker \
--score_mem 4 --score_cpus 4 \
--api_token ${PROD_TOKEN} \
--study_id TEST-CA \
--experiment_info_tsv input/prod_experiment-fq.v2.tsv \
--read_group_info_tsv input/prod_read_group-fq.v2.tsv \
--file_info_tsv input/prod_file-fq.v2.tsv \
--download_mode local \
--publish_dir outdir
nextflow run ../main.nf -params-file local-test-job-5-InputBam.json --skip_duplicate_check -profile rdpc_qa,docker --score_mem 4 --score_cpus 4 --api_token ${QA_TOKEN} --dry_run true
% nextflow run ../main.nf -params-file local-test-job-5-InputBam.json --skip_duplicate_check -profile rdpc_qa,docker --score_mem 4 --score_cpus 4
#N E X T F L O W  ~  version 22.10.6
#Launching `../main.nf` [peaceful_hodgkin] DSL2 - revision: d1e7ce6cd4
#WARN: Access to undefined parameter `api_download_token` -- Initialise it to a default value eg. `params.api_download_token = some_value`
#Error SONG parameters detected but missing token params. `--api_token` or `api_upload_token` and `api_download_token` must be supplied when uploading.

% nextflow run ../main.nf -params-file local-test-job-5-InputBam.json --skip_duplicate_check --api_token NNNNN --score_mem 4 --score_cpus 4
#N E X T F L O W  ~  version 22.10.6
#Launching `../main.nf` [loving_hamilton] DSL2 - revision: d1e7ce6cd4
#Error Missing profile. `-profile` must be specified with the engines :`docker` or `singularity`.


% nextflow run ../main.nf -params-file local-test-job-5-InputBam.json --skip_duplicate_check -profile docker --api_token NNNNN --score_mem 4 --score_cpus 4
#N E X T F L O W  ~  version 22.10.6
#Launching `../main.nf` [happy_pesquet] DSL2 - revision: d1e7ce6cd4
#Error Missing profile. `-profile` must be specified with the rdpc environments : `rdpc_qa`,`rdpc_dev`, or `rdpc`.

@edsu7 edsu7 self-assigned this Nov 30, 2023
@lindaxiang lindaxiang self-requested a review December 1, 2023 14:58
@@ -22,7 +22,7 @@
*/

nextflow.enable.dsl = 2
version = '1.0.3'
version = '1.0.4'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edsu7 can we bump the version to 1.1.0 as this version contains the url changes to backend infrastructure which are breaking changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For WFPM, would it be easier to start a new branch as 1.1.0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for sure, that's the only way I guess.

params.score_mem = 20
params.score_cpus = 8
params.score_force = false
params.dry_run = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We mentioned using -preview get a dry run in docs: https://docs.icgc-argo.org/docs/submission/submitting-molecular-data#quick-start
Can we use skip_upload instead here to differentiate them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we run the following command:
nextflow run -preview main.nf -params-file example-params.local.json
it will require us to set profile and provide api_token as well.
Any thoughts we can skip doing this if we run with -preview?

@edsu7
Copy link
Contributor Author

edsu7 commented Dec 1, 2023

@lindaxiang start new pull request in #94.
See changes there. Will close this one once 1.1.0 is approved.

@edsu7 edsu7 closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants