-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Argo data submission [email protected] #93
Conversation
@@ -22,7 +22,7 @@ | |||
*/ | |||
|
|||
nextflow.enable.dsl = 2 | |||
version = '1.0.3' | |||
version = '1.0.4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edsu7 can we bump the version to 1.1.0
as this version contains the url changes to backend infrastructure which are breaking changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For WFPM, would it be easier to start a new branch as 1.1.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for sure, that's the only way I guess.
params.score_mem = 20 | ||
params.score_cpus = 8 | ||
params.score_force = false | ||
params.dry_run = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We mentioned using -preview
get a dry run
in docs: https://docs.icgc-argo.org/docs/submission/submitting-molecular-data#quick-start
Can we use skip_upload
instead here to differentiate them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we run the following command:
nextflow run -preview main.nf -params-file example-params.local.json
it will require us to set profile and provide api_token as well.
Any thoughts we can skip doing this if we run with -preview
?
@lindaxiang start new pull request in #94. |
Addressing the following items: