Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update INSTALL.md #845

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update INSTALL.md #845

wants to merge 1 commit into from

Conversation

bleaktwig
Copy link

Cleared up the python version requirements when installing pisa through CVMFS and venv.

Cleared up the python version requirements when installing pisa through CVMFS and venv.
Copy link
Collaborator

@LeanderFischer LeanderFischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me.

@thehrh
Copy link
Contributor

thehrh commented Jan 13, 2025

Can someone explain?

@bleaktwig
Copy link
Author

bleaktwig commented Jan 13, 2025

Can someone explain?

In the Zeuthen wg server the default python version is 3.11, which breaks the pisa installation. Since the required python version is specified at the end of the INSTALL.md file, I thought it was a good idea to add this small warning so people don't accidentally try to install pisa with python 3.11 (which happened to me twice).

Then also running which python just tells you where the python you're using is installed, not which version it is, so that's why I replaced that part of the file.

@thehrh
Copy link
Contributor

thehrh commented Jan 13, 2025

The cvmfs method we support via these installation instructions specifically ensures that the py3-v4.2.1 cvmfs distribution is used. Why or how does your local WG server's default python version come into play?

Do you agree that

  • python version requirements are not specific to the cvmfs + venv install,
  • that the method we support, using the py3-v4.2.1 distribution, ensures the use of Python 3.10.2,
  • and that in this case the given output of which python is correct (and a valuable sanity check)?

@bleaktwig
Copy link
Author

Ok, sorry, I was missing some context in my explanation. The Zeuthen wg server uses RHEL 9, so the py3-v4.2.1 cvmfs distribution cannot be used since its only available up to RHEL 8. I can do a more thorough edit of the md file to explain how to install using py3-v4.2.1 and py3-v4.3.0.

@thehrh
Copy link
Contributor

thehrh commented Jan 13, 2025

I see. The instructions aren't meant to solve problems that arise from deviating from the supported method(s), even if you are obviously forced to do so here. (We used to have a wiki for any unofficial (for example site-specific) instructions, which didn't have to undergo review.)

Could you present your case and the solution you found for RHEL 9/py3-v4.3.0 in the developers channel on slack? That would allow us to jointly discuss whether this should replace the currently supported cmvfs installation method or whether it should be part of some less formal piece of documentation (for now).

@thehrh thehrh self-requested a review January 13, 2025 15:22
Copy link
Contributor

@thehrh thehrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants