Raise an exeption if the (not entirely implemented) analytical versio… #777
Conversation
…n of the effective NSI coupling matrix is accessed
finnmayhew
requested review from
1ofgp,
LeanderFischer and
VeronikaPalusova
and removed request for
1ofgp
|
Hm, running this function should probably not be in the unit tests since it's not implemented. |
| @@ -388,6 +388,9 @@ def eps_matrix(self): | |||
| def eps_matrix_analytical(self): | |||
| """Effective NSI coupling matrix calculated analytically.""" | |||
| # Analytical relations. These are wrong right now! #FIXME | |||
|
|
|||
| raise NotImplementedError("The analytical veresion of the effective NSI coupling matrix is not yet implemented.") | |||
There was a problem hiding this comment.
there is a typo here
Yeah, totally, but even a step before, why is this function (body) even there, if it's apparently not implemented? I suggest do get rid of it altogether, if there is no value in keeping the body and/or the function at all, no? Edit: Ah ok, this is in the process of being implemented? I suggest do leave incomplete code out of the master branch, work on it in a fork/branch until it is ready, and then get it in. Feel free to leave the empty function head and the NotImplementedError, but then take it out of the test of course 🙏 |
|
Solved through #786 |
…n of the effective NSI coupling matrix is accessed