Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of LRI potential #762

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Addition of LRI potential #762

merged 3 commits into from
Feb 16, 2024

Conversation

ggarg07
Copy link
Contributor

@ggarg07 ggarg07 commented Feb 6, 2024

Long Range Potential Analysis

  • Krishnamoorthi
  • Gopal

Introduced lriparams.py

  • Contains the LRIParams() class

Modified prob3.py

  • Introduced argument lri_type
  • Passed v_lri parameter
  • Modified propagate_array() to include lri_pot matrix

Modified numba_osc_kernels.py

  • Modified osc_probs_layers_kernel() to include lri_pot matrix
  • Modified get_transition_matrix(), addition of lri_pot with the matter hamiltonian

Modified numba_hostfunctions.py

  • Modified propagate_array()
  • Modified propagate_scalar()
  • Modified get_transition_matrix_hostfunc()
  • Modified get_transition_matrix()

Modified numba_osc_tests.py

  • Introdudced lri parameter value for the test

@sc458930 sc458930 merged commit f200ff8 into icecube:master Feb 16, 2024
2 checks passed
@LeanderFischer
Copy link
Collaborator

Did someone actually check this? 59 files changes is a whole lot?

@sc458930
Copy link
Contributor

Hi Leander, Krishnamoorthi had asked review from me. I went through their changes and approved them.

@LeanderFischer
Copy link
Collaborator

Hi Leander, Krishnamoorthi had asked review from me. I went through their changes and approved them.

Ok, that's good, apart from you merging, there was no sign of an actual review. Maybe next time when you go through the changes, especially if it is this many, write a comment that you looked at them and/or what you noticed etc., so that it's documented. For small changes, this isn't super important, but for big ones, it becomes easier to trace back what happened. Thanks!

@sc458930
Copy link
Contributor

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants