unset PYTHONPATH in cvmfs tests #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PYTHONPATH appears to be not only unnescessary but activly messing up the tests because the packages in system site-packages are old and incompatible with the latest version of pytest. Having system site-packages in PYTHONPATH causes them to be loaded first overriding what it is in .local/
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
=======================================
Coverage 92.57% 92.57%
=======================================
Files 12 12
Lines 700 700
Branches 328 328
=======================================
Hits 648 648
Misses 52 52 ☔ View full report in Codecov by Sentry. |
There is some binary incompatability issue with running the latest wheels from pypi on top of cvmfs python on top of the centos docker image that only applies to v4.2.x. I don't want to spend any more time trying to figure out. The testing regime is already pretty robust. So I am just gonna drop v4.2.1 and move on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PYTHONPATH appears to be not only unnescessary but activly messing up the tests
because the packages in system site-packages are old and incompatible with the
latest version of pytest. Having system site-packages in PYTHONPATH causes
them to be loaded first overriding what it is in .local/