fix: webpack config for dll plugin #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ClarkXia
commented
Aug 26, 2019
•
ClarkXia
commented
- fix: get default webpack config for build dll
- fix: html template
- fix: dll plugin only active in dev mode
tanhengyeow
reviewed
Aug 27, 2019
| return; | ||
| const hasVendor = (Array.from($('script')) || []).some(script => script.attribs.src === 'vendor.dll.js'); | ||
| if (!hasVendor) { | ||
| $('body').append('<script data-id="dll" src="vendor.dll.js"></script>'); |
There was a problem hiding this comment.
src="vendor.dll.js"
Should this be vendor.js instead?
Note to self: Added data-id="dll" to differentiate between scripts added by the DllPlugin and scripts added by default to the index.html file.
There was a problem hiding this comment.
If we want to use vendor.dll.js, we need to specify something like this in the webpack config:
output: {
filename: '[name].dll.js',
...
}
| } | ||
|
|
||
| // Check if vendor.js is included inside the HTML file | ||
| if ($('script').length === 1 && $('script')[0].attribs.src === "vendor.js") { | ||
| return; | ||
| const hasVendor = (Array.from($('script')) || []).some(script => script.attribs.src === 'vendor.dll.js'); |
There was a problem hiding this comment.
script.attribs.src === 'vendor.dll.js'
Should this be vendor.js instead?
There was a problem hiding this comment.
If we want to use vendor.dll.js, we need to specify something like this in the webpack config:
output: {
filename: '[name].dll.js',
...
}
tanhengyeow
approved these changes
Aug 27, 2019
imsobear
pushed a commit
that referenced
this pull request
Aug 27, 2019
* chore: version * chore: remove index.js (#40) * fix: deep copy babelConfig from webpack config * chore: rename typos (#45) * fix: set proxy headers when proxy server error (#47) * fix: set proxy headers when proxy server error * feat: only set enable: false will disable proxy * chore: eslint * feat: support calculate color variables for multi-theme (#44) * chore: add package resolve-sass-import * feat: support calculate color variables for @alifd/next * chore: version * chore: remove console log * chore: comment for regex * chore: rename typo and add readme example * fix: check match result * feat: support DllPlugin in ice-scripts (#48) * feat: support DllPlugin * chore: fix review comments * chore: refactor code * chore: fix review comments * fix: webpack config for dll plugin (#52) * fix: webpack config for dll plugin * fix: html template for dll * chore: typo and remove useless comment * fix: renanme dll output filename * feat: refactor webpack-dev-mock (#50) * feat: support index.ts * feat: dev mock is before devServer * chore: update verison * fix: hot reload mock * chore: adjust verison * style: code formatter * chore: add changelog.md * chore: adjust log verison * chore: changlog * style: code formatter (#54)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.