[minor] Support ppc64le architecture #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shajeena
requested review from
durera,
andrercm,
terenceq and
whitfiea
as code owners
|
Verified if there is no regression cause by these changes. tested in s390x cluster. |
durera
requested changes
Mar 4, 2025
durera
requested changes
Mar 5, 2025
There was a problem hiding this comment.
Also, the build is failing because the W3_USERNAME env var hasn't been registered in the workflow files where it's needed
e.g. like we have here for these ones:
env:
ARTIFACTORY_TOKEN: ${{ secrets.ARTIFACTORY_TOKEN }}
QUAYIO_USERNAME: ${{ secrets.QUAYIO_USERNAME }}
QUAYIO_PASSWORD: ${{ secrets.QUAYIO_PASSWORD }}
README.md
Outdated
| | `mongodump` v100.10.0 | ✔️ | ✔️ | ✔️ | ✔️ | | ||
| | `oc` | ✔️ | ✔️ | ✔️ | ✔️ | | ||
| | `oc mirror` | ✔️ | ✔️ | ✔️ | ✔️ | | ||
| | `oc ibm-pak` v1.16.2 | ✔️ | ✔️ | ✔️ | * Plug-in container-service is not supported | |
There was a problem hiding this comment.
this just needs to be the red X, or it will break the table formatting
|
|
||
| ARTIFACTORY_URL = "https://na.artifactory.swg-devops.com/artifactory/wiotp-generic-local/dependencies/wheels/s390x" | ||
| W3_USERNAME, ARTIFACTORY_TOKEN = "[email protected]", os.environ["ARTIFACTORY_TOKEN"] |
There was a problem hiding this comment.
Still have username hardcoded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to support architecture power ppc64le