run stored textual settings through i18n to allow translating saved v…

…alues. closes #793
ibericode · Jan 23, 2025 · a1e8c2b · a1e8c2b
1 parent 5a87264
commit a1e8c2b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/includes/forms/class-form.php b/includes/forms/class-form.php
@@ -296,7 +296,8 @@ protected function load_messages(array $post_meta = [])
                 $message_text = $post_meta[ 'text_' . $key ][0];
             }
 
-            $messages[ $key ] = $message_text;
+            // run final value through gettext filter to allow translation of stored setting values
+            $messages[ $key ] = __($message_text, 'mailchimp-for-wp');
         }
 
         return $messages;

diff --git a/includes/integrations/class-integration.php b/includes/integrations/class-integration.php
@@ -175,6 +175,11 @@ public function get_label_text()
             $label           = $default_options['label'];
         }
 
+        // run saved value through gettext filter
+        // this allows people to use a plugin like Loco Translate to translate this message
+        // without updating the setting itself
+        $label = __($label, 'mailchimp-for-wp');
+
         /**
          * Filters the checkbox label
          *