Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #215 , added support for Slate IFrame rendering, but in quite different way.
There is actually no need to pass
dom={...}
becasue valid window could be deducted by theevent.native.target
transparently.One more problem found in React
SelectionEventPlugin
: it also has hardcodedwindow
references.Basicly version of
SelectionEventPlugin
swallowing all onSelection events, and this leads to incosistent slection state in slate.To handle this I created small project react-frame-aware-selection-plugin
It is used in provided example.