This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
v2 #20
Merged
v2 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the offcanvas classes off the navbar element to the element that holds the navbar links. This leaves the navbar-header on the screen at all times. Also looking at improving the transitions between hidden & shown
| @target.on 'transitionend', => | ||
| console.log @target.is ':not(.in)' | ||
| if @target.is ':not(.in)' | ||
| @target.height '' |
There was a problem hiding this comment.
Line contains inconsistent indentation
A lot of dropdown CSS now falls back to Bootstraps - rather than overriding
Updated README
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the offcanvas classes off the navbar element to the element that holds the navbar links. This leaves the navbar-header on the screen at all times.
Also looking at improving the transitions between hidden & shown.
Going to also look at improving the styles all together. With a breaking release, might as well go all out!
Will close #19