Add isoWeekYear setter for Day.js ISO week handling #2800
+59
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces an isoWeekYear setter, allowing the ISO week year to be adjusted while preserving the current isoWeek and isoWeekday values. This change ensures consistent ISO-based date calculations and avoids unexpected behavior when using native .year() in combination with ISO week methods.
Background
In the current implementation, using
.year(...)
together with.isoWeek(...)
can lead to unexpected results. For example:This type of issue can recur in future years as well—for example, it is likely to occur again in years when December 31 belongs to the next year’s ISO week or January 1 still belongs to the previous year’s ISO week. A similar situation may arise in 2030 (or any year close to an ISO week boundary transition), leading to the same unexpected shift into the following calendar year.