Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Section Design #79

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Conversation

dev129
Copy link
Contributor

@dev129 dev129 commented Nov 3, 2024

Fixes : #70
Hi @iamkanhaiyakumar @GauravKesh

What does this PR do?

This PR addresses issue #70, which involves updates to the component located in /components/ui/review.tsx. The changes made improve the functionality of the review component by [briefly describe the specific changes made, e.g., "optimizing the rendering of user reviews" or "adding a feature to display user images dynamically"].

Motivation and Context

The motivation behind this change is to [explain why this change is necessary, e.g., "enhance user experience by ensuring reviews are visually engaging" or "fix a bug that caused user images not to load correctly"]. This change is expected to [describe the expected outcome, e.g., "improve performance" or "resolve user feedback issues"].

Dependencies

No new dependencies are required for this change.

Visual Changes

For visual changes, please refer to the screenshots included in this PR:

  • Screenshots:
    Mobile View:
    image

Desktop View:
image

Type of change

  • [] Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

To verify the changes, the following tests should be conducted:

  • [ x] Ensure that user images are displayed correctly based on the initial names provided.
  • [x ] Validate that the review component renders without errors.
  • [ x] Test responsiveness and layout on different screen sizes.

Test Configuration

  • Environment: [Specify any relevant details about the test environment, e.g., "React version", "Node version"]
  • Browser: [List the browsers you tested on, if applicable]

Mandatory Tasks

  • [ x] Make sure you have self-reviewed the code. A decent-sized PR without self-review might be rejected.

Copy link

vercel bot commented Nov 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai-content-generator ❌ Failed (Inspect) Nov 3, 2024 6:37pm

Copy link
Contributor

github-actions bot commented Nov 3, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for cool-boba-2a2b34 failed. Why did it fail? →

Name Link
🔨 Latest commit bf3241c
🔍 Latest deploy log https://app.netlify.com/sites/cool-boba-2a2b34/deploys/6727c2fca656e30008ce2a50

@dev129
Copy link
Contributor Author

dev129 commented Nov 3, 2024

Also let me clarify instead of npm i you need to use npm i --force

Copy link
Collaborator

@GauravKesh GauravKesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@GauravKesh GauravKesh merged commit d0241c4 into iamkanhaiyakumar:master Nov 4, 2024
2 of 9 checks passed
Copy link
Contributor

github-actions bot commented Nov 4, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

Copy link
Contributor

github-actions bot commented Nov 4, 2024

🎉🎉 Thank you for your contribution! Your PR #79 has been merged! 🎉🎉

@GauravKesh
Copy link
Collaborator

GauravKesh commented Nov 4, 2024

Also let me clarify instead of npm i you need to use npm i --force

@dev129 Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] Review Section Design at the landing page
2 participants