Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds data and README.md #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adds data and README.md #5

wants to merge 3 commits into from

Conversation

vinaysetty
Copy link
Contributor

Closes #2

Adds data files and code needed for creating the huggingface dataset.

Copy link
Collaborator

@peteraarnes peteraarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GeneratorBasedBuilder,
DownloadManager,
)
from datasets import SplitGenerator, Split, Features, Value
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be functions be sorted alphabetically?



class CLEF24EnData(GeneratorBasedBuilder):
"""A multilingual text dataset."""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and further: this is not multilingual dataset, the class can only contain English data.

}

return [
SplitGenerator(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split generator is a bit misleading name as it suggest that we are those generating the splits.

license=_LICENSE,
)

def _split_generators(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, the name sounds misleading to me.

Using `pre-commit` hooks, `flake8`, `black`, `mypy`, `docformatter`, and `pytest` are locally run on every commit. For more details on how to use `pre-commit` hooks see [here](https://github.com/iai-group/guidelines/tree/main/python#install-pre-commit-hooks).

Similarly, Github actions are used to run `flake8`, `black` and `pytest` on every push and pull request. The `pytest` results are sent to [CodeCov](https://about.codecov.io/) using their API for to get test coverage analysis. Details on Github actions are [here](https://github.com/iai-group/guidelines/blob/main/github/Actions.md).
This repo contains the code and data for the CLEF 2024 CheckThat! task1 IAI participation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be helpful to add a one-line explanation of the task and also the link to checkthat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Dataset class for task-1
3 participants