Remove deprecated 3.x APIs in core-common

common/api/core-common.api.md

@@ -468,10 +468,10 @@ export class BackendError extends IModelError {
     constructor(errorNumber: number, name: string, message: string, getMetaData?: LoggingMetaData);
 }
 
-// @public @deprecated (undocumented)
+// @internal @deprecated (undocumented)
 export type BackendReadable = Readable;
 
-// @public @deprecated (undocumented)
+// @internal @deprecated (undocumented)
 export type BackendWritable = Writable;
 
 // @public
@@ -1290,9 +1290,6 @@ export class CodeSpec {
     iModel: IModel;
     // (undocumented)
     get isExternal(): boolean;
-    // @deprecated
-    get isManagedWithIModel(): boolean;
-    set isManagedWithIModel(value: boolean);
     get isValid(): boolean;
     name: string;
     // @internal
@@ -3344,12 +3341,6 @@ export class FeatureOverrides implements FeatureAppearanceSource {
     readonly neverDrawnAnimationNodes: Set<number>;
     override(args: OverrideFeatureAppearanceArgs): void;
     overrideAnimationNode(id: number, app: FeatureAppearance): void;
-    // @deprecated
-    overrideElement(id: Id64String, app: FeatureAppearance, replaceExisting?: boolean): void;
-    // @deprecated
-    overrideModel(id: Id64String, app: FeatureAppearance, replaceExisting?: boolean): void;
-    // @deprecated
-    overrideSubCategory(id: Id64String, app: FeatureAppearance, replaceExisting?: boolean): void;
     protected _patterns: boolean;
     setAlwaysDrawn(id: Id64String): void;
     setAlwaysDrawnSet(ids: Iterable<Id64String>, exclusive: boolean, ignoreSubCategory?: boolean): void;
@@ -4652,8 +4643,6 @@ export interface HydrateViewStateRequestProps {
     acsId?: string;
     // (undocumented)
     baseModelId?: Id64String;
-    // @deprecated (undocumented)
-    notLoadedCategoryIds?: CompressedId64Set;
     // (undocumented)
     notLoadedModelSelectorStateModels?: CompressedId64Set;
     // (undocumented)
@@ -4670,8 +4659,6 @@ export interface HydrateViewStateResponseProps {
     acsElementProps?: ElementProps;
     // (undocumented)
     baseModelProps?: ModelProps;
-    // @deprecated (undocumented)
-    categoryIdsResult?: SubCategoryResultRow[];
     // (undocumented)
     modelSelectorStateModels?: ModelProps[];
     // (undocumented)
@@ -5678,8 +5665,6 @@ export interface Localization {
     getLanguageList(): readonly string[];
     getLocalizedKeys(inputString: string): string;
     getLocalizedString(key: string | string[], options?: TranslationOptions): string;
-    // @deprecated
-    getLocalizedStringWithNamespace(namespace: string, key: string | string[], options?: TranslationOptions): string;
     // @internal (undocumented)
     getNamespacePromise(name: string): Promise<void> | undefined;
     initialize(namespaces: string[]): Promise<void>;
@@ -7664,7 +7649,7 @@ export abstract class RenderMaterial {
 
 // @public (undocumented)
 export namespace RenderMaterial {
-    // @deprecated (undocumented)
+    // @internal
     export class Params {
         constructor(key?: string);
         get alpha(): number | undefined;
@@ -8093,7 +8078,7 @@ export abstract class RenderTexture implements Disposable {
 
 // @public (undocumented)
 export namespace RenderTexture {
-    // @deprecated
+    // @internal
     export class Params {
         constructor(key?: string, type?: RenderTexture.Type, isOwned?: boolean);
         // (undocumented)
@@ -9635,9 +9620,6 @@ export interface TerrainProps {
     providerName?: string;
 }
 
-// @public @deprecated
-export type TerrainProviderName = string;
-
 // @public
 export class TerrainSettings {
     // @deprecated

common/api/summary/core-common.exports.csv

@@ -31,9 +31,9 @@ internal;class;B3dmHeader
 internal;type;BackendBuffer
 deprecated;type;BackendBuffer
 public;class;BackendError
-public;type;BackendReadable
+internal;type;BackendReadable
 deprecated;type;BackendReadable
-public;type;BackendWritable
+internal;type;BackendWritable
 deprecated;type;BackendWritable
 public;enum;BackgroundFill
 public;interface;BackgroundMapProps
@@ -676,6 +676,7 @@ public;type;RemoveFunction
 public;interface;RenderFeatureTable
 public;class;RenderMaterial
 public;namespace;RenderMaterial
+internal;class;Params
 public;interface;RenderMaterialAssetMapsProps
 public;interface;RenderMaterialAssetProps
 public;interface;RenderMaterialProps
@@ -684,6 +685,7 @@ public;namespace;RenderSchedule
 internal;class;Interval
 public;class;RenderTexture
 public;namespace;RenderTexture
+internal;class;Params
 public;interface;RenderTimelineLoadProps
 public;interface;RenderTimelineProps
 public;interface;RepositoryLinkProps
@@ -829,8 +831,6 @@ beta;interface;SynchronizationConfigLinkProps
 public;enum;SyncMode
 public;enum;TerrainHeightOriginMode
 public;interface;TerrainProps
-public;type;TerrainProviderName
-deprecated;type;TerrainProviderName
 public;class;TerrainSettings
 internal;class;TestRpcManager
 beta;class;TextAnnotation

common/changes/@itwin/core-backend/mike-remove-deprecated-corecommon_2025-01-31-16-39.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@itwin/core-backend",
+      "comment": "Remove 3.x Deprecated APIs",
+      "type": "none"
+    }
+  ],
+  "packageName": "@itwin/core-backend"
+}

common/changes/@itwin/core-common/mike-remove-deprecated-corecommon_2025-01-31-16-39.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@itwin/core-common",
+      "comment": "Remove 3.x Deprecated APIs",
+      "type": "none"
+    }
+  ],
+  "packageName": "@itwin/core-common"
+}

common/changes/@itwin/core-extension/mike-remove-deprecated-corecommon_2025-01-31-16-39.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@itwin/core-extension",
+      "comment": "Remove 3.x Deprecated APIs",
+      "type": "none"
+    }
+  ],
+  "packageName": "@itwin/core-extension"
+}

core/backend/src/ViewStateHydrator.ts

@@ -3,7 +3,7 @@
 * See LICENSE.md in the project root for license terms and full copyright notice.
 *--------------------------------------------------------------------------------------------*/
 import { BentleyError, CompressedId64Set, Id64String, Logger } from "@itwin/core-bentley";
-import { HydrateViewStateRequestProps, HydrateViewStateResponseProps, ModelProps, SubCategoryResultRow, ViewAttachmentProps, ViewStateLoadProps } from "@itwin/core-common";
+import { HydrateViewStateRequestProps, HydrateViewStateResponseProps, ModelProps, ViewAttachmentProps, ViewStateLoadProps } from "@itwin/core-common";
 import { BackendLoggerCategory } from "./BackendLoggerCategory";
 import { IModelDb } from "./IModelDb";
 
@@ -21,11 +21,6 @@ export class ViewStateHydrator {
       promises.push(this.handleAcsId(response, options.acsId));
     if (options.sheetViewAttachmentIds)
       promises.push(this.handleSheetViewAttachmentIds(response, options.sheetViewAttachmentIds, options.viewStateLoadProps));
-    // eslint-disable-next-line @typescript-eslint/no-deprecated
-    if (options.notLoadedCategoryIds) {
-      // eslint-disable-next-line @typescript-eslint/no-deprecated
-      promises.push(this.handleCategoryIds(response, options.notLoadedCategoryIds));
-    }
     if (options.spatialViewId)
       promises.push(this.handleSpatialViewId(response, options.spatialViewId, options.viewStateLoadProps));
     if (options.notLoadedModelSelectorStateModels)
@@ -36,14 +31,6 @@ export class ViewStateHydrator {
     return response;
   }
 
-  private async handleCategoryIds(response: HydrateViewStateResponseProps, categoryIds: CompressedId64Set) {
-    const decompressedIds = CompressedId64Set.decompressArray(categoryIds);
-    const results: SubCategoryResultRow[] = await this._imodel.querySubCategories(decompressedIds);
-
-    // eslint-disable-next-line @typescript-eslint/no-deprecated
-    response.categoryIdsResult = results;
-  }
-
   private async handleBaseModelId(response: HydrateViewStateResponseProps, baseModelId: Id64String) {
     let modelProps;
     try {

core/common/src/BackendTypes.ts

@@ -16,10 +16,10 @@ Do not add any new types to this file.
 All types here will be removed in 4.0
 */
 
-/** @public @deprecated in 3.x. This type was mistakenly made public in the common scope. */
+/** @internal @deprecated in 3.x. This type was mistakenly made public in the common scope. */
 export type BackendReadable = Readable;
 
-/** @public @deprecated in 3.x. This type was mistakenly made public in the common scope. */
+/** @internal @deprecated in 3.x. This type was mistakenly made public in the common scope. */
 export type BackendWritable = Writable;
 
 /** @internal @deprecated in 3.x. This type was mistakenly made public in the common scope. */

core/common/src/Code.ts

@@ -333,17 +333,4 @@ export class CodeSpec {
     else
       this.properties.scopeSpec.fGuidRequired = undefined;
   }
-
-  /** Will be true if the codes associated with this CodeSpec are managed along with the iModel and false if the codes are managed by an external service.
-   * @deprecated in 3.6 Use scopeReq instead.
-   */
-  public get isManagedWithIModel(): boolean {
-    return this.properties.spec?.isManagedWithDgnDb ?? true;
-  }
-  public set isManagedWithIModel(value: boolean) {
-    if (!this.properties.spec)
-      this.properties.spec = {};
-
-    this.properties.spec.isManagedWithDgnDb = value;
-  }
 }

core/common/src/FeatureSymbology.ts

@@ -817,42 +817,6 @@ export class FeatureOverrides implements FeatureAppearanceSource {
     map.set(idLo, idHi, app);
   }
 
-  /** Specify overrides for all elements within the specified model.
-   * @param id The Id of the model.
-   * @param app The symbology overrides.
-   * @param replaceExisting Specifies whether to replace a pre-existing override for the same model.
-   * @note These overrides take priority over all other overrides.
-   * @note If [[defaultOverrides]] are defined, they will not apply to any element within this model, even if the supplied appearance overrides nothing.
-   * @deprecated in 3.x. Use [[FeatureOverrides.override]].
-   */
-  public overrideModel(id: Id64String, app: FeatureAppearance, replaceExisting: boolean = true): void {
-    this.override({ modelId: id, appearance: app, onConflict: replaceExisting ? "replace" : "skip" });
-  }
-
-  /** Specify overrides for all geometry belonging to the specified [SubCategory]($backend).
-   * @param id The Id of the subcategory.
-   * @param app The symbology overrides.
-   * @param replaceExisting Specifies whether to replace a pre-existing override for the same subcategory.
-   * @note These overrides have lower priority than element and model overrides.
-   * @note If [[defaultOverrides]] are defined, they will not apply to any geometry within this subcategory, even if the supplied appearance overrides nothing.
-   * @deprecated in 3.x. Use [[FeatureOverrides.override]].
-   */
-  public overrideSubCategory(id: Id64String, app: FeatureAppearance, replaceExisting: boolean = true): void {
-    this.override({ subCategoryId: id, appearance: app, onConflict: replaceExisting ? "replace" : "skip" });
-  }
-
-  /** Specify overrides for all geometry originating from the specified element.
-   * @param id The Id of the element.
-   * @param app The symbology overrides.
-   * @param replaceExisting Specifies whether to replace a pre-existing override for the same element.
-   * @note These overrides take precedence over subcategory overrides, but not over model overrides.
-   * @note If [[defaultOverrides]] are defined, they will not apply to this element, even if the supplied appearance overrides nothing.
-   * @deprecated in 3.x. Use [[FeatureOverrides.override]].
-   */
-  public overrideElement(id: Id64String, app: FeatureAppearance, replaceExisting: boolean = true): void {
-    this.override({ elementId: id, appearance: app, onConflict: replaceExisting ? "replace" : "skip" });
-  }
-
   /** Specify overrides for all geometry originating from the specified animation node.
    * @param id The Id of the animation node.
    * @param app The symbology overrides.

core/common/src/Localization.ts

@@ -60,15 +60,6 @@ export interface Localization {
    * @throws Error if no keys resolve to a string.
    */
   getLocalizedString(key: string | string[], options?: TranslationOptions): string;
-  /** Similar to `getLocalizedString` but the namespace is a separate param and the key does not include the namespace.
-   * @param namespace - the namespace that identifies the particular localization file that contains the property.
-   * @param key - the key that matches a property in the JSON localization file.
-   * @returns The string corresponding to the first key that resolves.
-   * @throws Error if no keys resolve to a string.
-   * @deprecated in 3.x. Use `getLocalizedString` instead; providing either a key with a namespace `<namespace>:<key>` or
-   * including `{ ns: <namespace> }` in the options.
-   */
-  getLocalizedStringWithNamespace(namespace: string, key: string | string[], options?: TranslationOptions): string;
   /** get the English string for a key. */
   getEnglishString(namespace: string, key: string | string[], options?: TranslationOptions): string;
   /** Replace all instances of `%{key}` within a string with the translations of those keys.

core/common/src/RenderMaterial.ts

@@ -43,7 +43,9 @@ export namespace RenderMaterial {
     return Math.max(0.0, Math.min(1.0, value));
   }
 
-  /** @deprecated in 3.x. Use [CreateRenderMaterialArgs]($frontend). */
+  /** Params for use in old CreateMaterial functions. Use [CreateRenderMaterialArgs]($frontend) instead.
+   * @internal
+  */
   export class Params {
     /** If the material originates from a Material element in the [[IModel]], the Id of that element. */
     public key?: string;
@@ -75,7 +77,6 @@ export namespace RenderMaterial {
     public constructor(key?: string) { this.key = key; }
 
     /** Obtain an immutable instance of a RenderMaterial with all default properties. */
-    // eslint-disable-next-line @typescript-eslint/no-deprecated
     public static readonly defaults = new Params();
 
     /** A value from 0.0 (fully-transparent) to 1.0 (fully-opaque) controlling the transparency of surfaces to which this material is applied;
@@ -87,9 +88,7 @@ export namespace RenderMaterial {
     }
 
     /** Create a RenderMaterial params object using specified key and ColorDef values, as well as an optional texture mapping. */
-    // eslint-disable-next-line @typescript-eslint/no-deprecated
     public static fromColors(key?: string, diffuseColor?: ColorDef, specularColor?: ColorDef, emissiveColor?: ColorDef, reflectColor?: ColorDef, textureMap?: TextureMapping): Params {
-      // eslint-disable-next-line @typescript-eslint/no-deprecated
       const materialParams = new Params();
       materialParams.key = key;
       materialParams.diffuseColor = diffuseColor;
@@ -102,5 +101,5 @@ export namespace RenderMaterial {
   }
 }
 
-// eslint-disable-next-line @typescript-eslint/no-deprecated
+
 Object.freeze(RenderMaterial.Params.defaults);

core/common/src/RenderTexture.ts

@@ -75,8 +75,8 @@ export namespace RenderTexture {
   }
 
   /** Parameters used to construct a [[RenderTexture]].
-   * @deprecated in 3.x. use RenderSystem.createTexture and CreateTextureArgs.
-   * @public
+   *  Use RenderSystem.createTexture and CreateTextureArgs.
+   *  @internal
    */
   export class Params {
     /** A string uniquely identifying this texture within the context of an [[IModel]]. Typically this is the element Id of the corresponding [Texture]($backend) element.

core/common/src/TerrainSettings.ts

@@ -8,14 +8,6 @@
 
 import { BackgroundMapProps } from "./BackgroundMapSettings";
 
-/** Identifies a [TerrainProvider]($frontend).
- * @see [[TerrainSettings.providerName]] and [[TerrainProps.providerName]].
- * @public
- * @extensions
- * @deprecated in 3.x. Use string instead.
- */
-export type TerrainProviderName = string;
-
 /** Ids of [Cesium ION assets](https://cesium.com/platform/cesium-ion/content/) providing global terrain data.
  * These values are appropriate to use with [[TerrainSettings.dataSource]] when [[TerrainSettings.providerName]] is set to "CesiumWorldTerrain".
  * You may alternatively use the Id of any ION asset to which you have access.

core/common/src/ViewProps.ts

@@ -71,8 +71,6 @@ export interface SubCategoryResultRow {
 export interface HydrateViewStateRequestProps {
   acsId?: string;
   notLoadedModelSelectorStateModels?: CompressedId64Set;
-  /** @deprecated in 3.x. If loading categoryIds is necessary, see [IModelConnection.SubCategoriesCache.load]($frontend)*/
-  notLoadedCategoryIds?: CompressedId64Set;
   sheetViewAttachmentIds?: CompressedId64Set;
   viewStateLoadProps?: ViewStateLoadProps;
   baseModelId?: Id64String;
@@ -90,8 +88,6 @@ export interface HydrateViewStateResponseProps {
   sheetViewViews?: (ViewStateProps | undefined)[];
   baseModelProps?: ModelProps;
   spatialViewProps?: ViewStateProps;
-  /** @deprecated in 3.x. If loading categoryIds is necessary, see [IModelConnection.SubCategoriesCache.load]($frontend)*/
-  categoryIdsResult?: SubCategoryResultRow[];
 }
 
 /** Returned from [IModelDb.Views.getViewStateData]($backend).