Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-focus AccuDraw distance field #753

Merged
merged 8 commits into from
Mar 5, 2024
Merged

Auto-focus AccuDraw distance field #753

merged 8 commits into from
Mar 5, 2024

Conversation

GerardasB
Copy link
Collaborator

@GerardasB GerardasB commented Mar 4, 2024

Changes

This PR fixes iTwin/itwinjs-core#6478 by correctly focusing the distance field when AccuDraw is in polar mode.
Distance field will now be rendered above angle field to match legacy behavior.

Screenshot 2024-03-04 at 15 11 03

Testing

Tested via standalone test-app.

@GerardasB GerardasB requested a review from a team as a code owner March 4, 2024 13:11
@GerardasB GerardasB requested a review from bbastings March 4, 2024 13:25
@GerardasB
Copy link
Collaborator Author

Additionally I've opened #754 to track other improvements for the AccuDraw.

Copy link
Contributor

@bbastings bbastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@GerardasB GerardasB enabled auto-merge (squash) March 4, 2024 13:36
@GerardasB GerardasB merged commit 7ddc375 into master Mar 5, 2024
20 checks passed
@GerardasB GerardasB deleted the fix-accudraw-focus branch March 5, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AccuDraw dialog/widget is not working correctly in polar mode.
3 participants