Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly dock closed popout widget to panel section #621

Merged
merged 21 commits into from
Dec 14, 2023
Merged

Conversation

GerardasB
Copy link
Collaborator

Changes

Fixes #202. Correctly docks a closed popout widget to the panel section from which the widget was popped out.

Testing

Added additional e2e test.

@GerardasB GerardasB requested a review from a team as a code owner December 7, 2023 16:00
@GerardasB GerardasB enabled auto-merge (squash) December 12, 2023 08:57
Copy link
Contributor

@raplemie raplemie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent improvement !

Copy link
Contributor

@raplemie raplemie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GerardasB GerardasB merged commit 83ed05f into master Dec 14, 2023
17 checks passed
@GerardasB GerardasB deleted the issue-202 branch December 14, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

canPopout: if frontstage is switched while popout is open, it does not return to original position
2 participants