Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ActiveSelectionScope relative documentation #570

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Update ActiveSelectionScope relative documentation #570

merged 2 commits into from
Oct 31, 2023

Conversation

raplemie
Copy link
Contributor

Changes

  • Updated SelectionScopeField documentation to clarify after the removal of the @itwin/presentation-frontend package.
  • Updated UiFramework selection scope related methods to clarify the expected usage.
  • Updated SelectionScopeField typing to "lock" the type so we no longer have issues with extract-api. The type did NOT change, only the way of writing it.

Testing

N/A (documentation)

Issue

resolves #569

@raplemie raplemie requested a review from a team as a code owner October 30, 2023 16:35
@raplemie raplemie enabled auto-merge (squash) October 30, 2023 16:35
@raplemie raplemie added the patch Changes in this PR requires a patch release label Oct 30, 2023
@raplemie raplemie merged commit 4126ae5 into master Oct 31, 2023
17 checks passed
@raplemie raplemie deleted the raplemie/selectionScopesDoc branch October 31, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GerardasB GerardasB GerardasB approved these changes

Assignees
No one assigned
Labels
patch Changes in this PR requires a patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix SelectionScopeField documentation
2 participants
@raplemie @GerardasB