Fix unneeded changeView call being done on mount
#565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GerardasB
approved these changes
Oct 30, 2023
|
@Mergifyio backport release/4.6.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 17, 2023
(cherry picked from commit 65d9e3f) # Conflicts: # docs/changehistory/NextVersion.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ViewportComponent: Remove the default evaluation of theviewStatein theuseStateinitialiser because it gets automatically reset toundefinedafterwards, but was causing a creation of the viewport (fulfilling theviewportRefthen reassigned theviewStatevalue that had just been recalculated. Since we want to reset the view when a new viewState is provided, we can't remove the "set...(undefined)", so simply starting with undefined resolves this issue.FloatingViewportContent: ThechangeViewcall is not necessary because a newviewstatecause the viewportControl to be rememoized, which handles the viewstate change itself. However having it was causing any changes to the viewport (for example in the ref call) to be ignored/reset.Testing
Tested manually in many scenario, mainly using "Content Layout" and "Content popout" fronstages. All unit and visual tests passes.
Issue
fixes #371