Fix popout widget issue when useDefaultPopoutUrl is not used (backport #1179)
#1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Add IMJS_USE_DEFAULT_POPOUT_URL * Replace deprecated document.write * rush change * useDefaultPopoutUrl url param. * Add tests (cherry picked from commit d867e2d)
GerardasB
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes #1178 by replacing deprecated
document.write()with DOM manipulation methods.Popout widget would not close correctly, due to
pagehidelistener not being called. See https://developer.mozilla.org/en-US/docs/Web/API/Document/open#notesI.e. using
document.close()(after writing to the document) and then adding thepagehidelistener seems to work correctly as well.Testing
N/A
This is an automatic backport of pull request #1179 done by [Mergify](https://mergify.com).