Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use import attributes when importing json files #1174

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Conversation

GerardasB
Copy link
Collaborator

Changes

This fixes #1165 by using import attributes when importing translation string files (json files).

Testing

N/A

@GerardasB GerardasB requested a review from a team as a code owner January 15, 2025 15:12
@GerardasB GerardasB self-assigned this Jan 15, 2025
@GerardasB GerardasB added the patch Changes in this PR requires a patch release label Jan 15, 2025
@GerardasB GerardasB merged commit cc00785 into master Jan 16, 2025
20 checks passed
@GerardasB GerardasB deleted the issue-1165 branch January 16, 2025 11:39
@GerardasB
Copy link
Collaborator Author

@Mergifyio backport release/5.0.x

@GerardasB
Copy link
Collaborator Author

@Mergifyio backport release/5.1.x

Copy link
Contributor

mergify bot commented Jan 16, 2025

backport release/5.0.x

✅ Backports have been created

Copy link
Contributor

mergify bot commented Jan 16, 2025

backport release/5.1.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 16, 2025
* Use import attributes for json imports.

* rush change

* Add useTranslation to prettierignore

(cherry picked from commit cc00785)
mergify bot pushed a commit that referenced this pull request Jan 16, 2025
* Use import attributes for json imports.

* rush change

* Add useTranslation to prettierignore

(cherry picked from commit cc00785)
GerardasB added a commit that referenced this pull request Jan 16, 2025
* Use import attributes for json imports.

* rush change

* Add useTranslation to prettierignore

(cherry picked from commit cc00785)

Co-authored-by: GerardasB <[email protected]>
GerardasB added a commit that referenced this pull request Jan 16, 2025
* Use import attributes for json imports.

* rush change

* Add useTranslation to prettierignore

(cherry picked from commit cc00785)

Co-authored-by: GerardasB <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Changes in this PR requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runtime error ERR_IMPORT_ASSERTION_TYPE_MISSING when loading AppUI modules
2 participants