Update accudraw core 4 11 #1169
Conversation
| @@ -156,14 +161,10 @@ export function AccuDrawFieldContainer(props: AccuDrawFieldContainerProps) { | |||
|
|
|||
| React.useEffect(() => { | |||
| // Set the focus to the first input field when the component is mounted and when the compass mode changes. | |||
| const itemToFocus = | |||
| mode === CompassMode.Polar ? ItemField.DIST_Item : ItemField.X_Item; | |||
| const itemToFocus = IModelApp.accuDraw.defaultFocusItem(); | |||
There was a problem hiding this comment.
IModelApp.accuDraw.defaultFocusItem does this exist in @itwin/[email protected]?
There was a problem hiding this comment.
No, it'll be available in 4.11
There was a problem hiding this comment.
We need to support ^4.0.0 as indicated in package.json
There was a problem hiding this comment.
@bbastings
Any idea to make this fix, retro compatible to ^4.0.0 ?
There was a problem hiding this comment.
Just make local copies for now, or keep the old code. These changes aren't enough to fix AccuDraw anyway, I'm still working on it and nothing is getting merged into anything before 4.11.
public defaultFocusItem(): ItemField { return (CompassMode.Polar === this.compassMode ? ItemField.DIST_Item : this.newFocus); }
Will complain about missing override once itwin core packages are updated so you'll know it can be removed.
There was a problem hiding this comment.
@GerardasB
Can we just bump the peer to 4.11 when released ?
There was a problem hiding this comment.
No, since that requires a new major version. Before calling a potentially nonexistent API simply check if it is defined. Alternatively - maybe https://www.itwinjs.org/reference/core-frontend/imodelapp/itwinjs_core_version/ can be used.
In either case - seems like there needs to be some branching to support both pre and after 4.11
| async function acceptInputValue(itemField: ItemField) { | ||
| await AccuDrawShortcuts.itemFieldAcceptInput( | ||
| itemField, | ||
| IModelApp.accuDraw.getFormattedValueByIndex(itemField) |
There was a problem hiding this comment.
IModelApp.accuDraw.getFormattedValueByIndex does this exist in @itwin/[email protected]?
There was a problem hiding this comment.
No, it'll be available in 4.11
There was a problem hiding this comment.
This requires the changes to add the parsers to core AccuDraw, so yeah...f we can't upgrade to 4.11 may as well just revert these changes.
Accudraw updates for ITwin-Core 4.11
ITwin core 4.11 is not released yet, thus the Draft PR.
Apply updates required by these PRs in Core :
itwinjs-core/pull/7488
itwinjs-core/pull/7492
Input field now updates to the formatted value when losing focus.
Using the updated API.