-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accudraw update fixes #1157
Accudraw update fixes #1157
Conversation
…n the mouse move and when typing in the inputs.
ui/appui-react/src/appui-react/accudraw/AccuDrawFieldContainer.tsx
Outdated
Show resolved
Hide resolved
…ng accudraw values
common/changes/@itwin/appui-react/accudraw_update_fixes_2024-12-13-20-55.json
Outdated
Show resolved
Hide resolved
ui/appui-react/src/appui-react/accudraw/AccuDrawFieldContainer.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, I'd appreciate if we could update (in separate PR) AccuDraw.md
to actually describe what accu draw is and how it is expected to work.
I'll do it in another PR, AccuDraw doc is probably already in Core. I'll link this doc and make a fresh doc for FrameworkAccuDraw |
@mathieu-fournier There's an AccuDraw section in the learning docs (PrimitiveTool.md) but since there's no UI in core it's pretty bare bones. |
Should we put the doc in core or appui ? |
@mathieu-fournier Document in appui so you can reference/link ui classes, etc. |
Changes
This PR goes hand in hand with some fixes that have been made in Core-frontend : itwinjs-core/pull/7475.
This stabilizes AccuDraw behaviours in general.
Fixes :
1- When moving the mouse, the focus only change between X or Y in rectangular mode only.
2- Revereted that fix, it will need to be done in another PR. See the comments. Only updating input fields value when their state is dynamic. Reason :
onMotion
is supposed to be called way more often, like on every key typed. This prevents the input field from updating at the wrong moment. (Works with the core-frontend fix)3- Removed the delay after typing in the input field, the visual update should be immediate. (Works with the core-frontend fix)
4- Input fields are automatically focused when the AccuDrawFieldContainer appears and the the compass mode changes.
Improvements :
5- Rectangular inputs no longer have colors.
6- We can enter letters in the Bearing angle input field.
N, S, E, W
for North, South, East and West.7- Bearing angle input field automatically adds special characters
° ' "
to facilitate entering bearing angles.8- The Focus is now trapped in Accudraw input fields. To focus out of these fields, the user must press Escape.
Thanks (:
Mathf