Remove @bentley/icons-generic from AppUI packages
#1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saskliutas
approved these changes
Dec 11, 2024
|
@Mergifyio backport release/5.0.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
* Remove unused icons-generic dependency * Avoid icons-generic usage in SnapMode field. * Remove icons-generic from appui-react * rush change * Remove leftover getIconNode * Remove failing tests that test the DOM structure. * Fix endIcon styling. (cherry picked from commit 594690c) # Conflicts: # common/config/rush/pnpm-lock.yaml # ui/appui-react/src/appui-react/statusfields/SnapMode.tsx
GerardasB
added a commit
that referenced
this pull request
Dec 12, 2024
…1155) * Remove `@bentley/icons-generic` from AppUI packages (#1153) * Remove unused icons-generic dependency * Avoid icons-generic usage in SnapMode field. * Remove icons-generic from appui-react * rush change * Remove leftover getIconNode * Remove failing tests that test the DOM structure. * Fix endIcon styling. (cherry picked from commit 594690c) # Conflicts: # common/config/rush/pnpm-lock.yaml # ui/appui-react/src/appui-react/statusfields/SnapMode.tsx * Fix merge conflicts --------- Co-authored-by: GerardasB <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR resolves #798 by removing dependency on deprecated
@bentley/icons-genericpackage.Testing
N/A