animation: let callbacks have SP's to the self variable and dispatch them internally #38
+49
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…them internally To be absolutely sure that adding/removing callbacks can't cause problems, dispatch them in tickDone outside of the loop. I think looping over all the vars twice is still better than having disconnectFromActive handle the removal, because that needs to search for each variable in the active vector.
reasoning? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I lost the confidence that just looping over indices makes it safe. Haven't seen a crash per se, but after rethinking, I think this is better to be safe.
This breaks the ABI (callback WP->SP), so I also included the virtual dtor here in case we merge this.
Also
onUpdateneed to be removed from thetickmethod in hyprland/lock, cause that is now handled intickDone