-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auth: fixup prompt and fail substitution #641
Conversation
a44215b
to
556cc86
Compare
After pondering with @alba4k we thought removing $FAIL and |
BREAKING: - Removed $PROMPT variable. Either use $PAMPROMPT or $FPRINTPROMPT. - Removed $FPRINTMESSAGE. Use $FPRINTPROMPT instead. There is also $FPRINTFAIL.
@vaxerski this one is ready. Regarding the breaking variable changes (PROMPT & FPRINTMESSAGE), i could instead:
Let me know if you think any of those make more sense. |
I think they can be safely be removed, but if you really want to be safe the easiest solution is probably to just keep them working for a while and print a warning to stderr saying that the variable is deprecated and will be removed soon. |
why do the breaking changes? is there any good reason? |
FPRINTMESSAGE is a misleading name, FPRINTFAIL is more consistent with the other variables and explains the purpose of the variable better a unified PROMT variable doesn't really make sense with more than one auth method. Separating the variables makes more sense and gives the user more control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. Wiki mr?
oops, already there. |
This PR brings back fingerprint errors in
$FAIL
. That was regressed by #603.BREAKING:
$FPRINTFAIL.