Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input-field: new color features #201

Merged
merged 10 commits into from
Mar 19, 2024
Merged

input-field: new color features #201

merged 10 commits into from
Mar 19, 2024

Conversation

bvr-yr
Copy link
Contributor

@bvr-yr bvr-yr commented Mar 17, 2024

  • new swap_font option (see on videos)
  • now when outline_thickness = 0 (aka borderless) inner box color will be changed instead

this is how it looks

borderless with swap_font:
will change dots color to inner, that's for cases bright font looks ugly on colored box

borderless.mp4

normal with swap_font:
will swap inner and font on check and failure

normal.mp4

now i think we should deprecate fail_transition in favour of color_transition
how it is handled correctly?

@bvr-yr
Copy link
Contributor Author

bvr-yr commented Mar 17, 2024

for some reason failasset stopped showing after certain commit when hitting enter on empty input, i added workaround for now

@vaxerski
Copy link
Member

why is this called swap_font?

@bvr-yr
Copy link
Contributor Author

bvr-yr commented Mar 17, 2024

i'm bad at namings. dunno, swap_font_color?

@vaxerski
Copy link
Member

more like that, yea, it deals with colors after all

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bvr-yr bvr-yr requested a review from vaxerski March 18, 2024 22:53
@bvr-yr
Copy link
Contributor Author

bvr-yr commented Mar 18, 2024

check please if everything is alright in last commit

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk looks reasonable

@vaxerski vaxerski merged commit 1bf6ffd into hyprwm:main Mar 19, 2024
1 check passed
@bvr-yr bvr-yr deleted the colors branch March 19, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants