-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
input-field: new color features #201
Conversation
for some reason failasset stopped showing after certain commit when hitting enter on empty input, i added workaround for now |
why is this called swap_font? |
i'm bad at namings. dunno, |
more like that, yea, it deals with colors after all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
check please if everything is alright in last commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk looks reasonable
swap_font
option (see on videos)outline_thickness = 0
(aka borderless) inner box color will be changed insteadthis is how it looks
borderless with
swap_font
:will change dots color to inner, that's for cases bright font looks ugly on colored box
borderless.mp4
normal with
swap_font
:will swap inner and font on check and failure
normal.mp4
now i think we should deprecate
fail_transition
in favour ofcolor_transition
how it is handled correctly?