Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input-field: add capslock and numlock options #182

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Conversation

bvr-yr
Copy link
Contributor

@bvr-yr bvr-yr commented Mar 12, 2024

  • capslock_color
  • numlock_color
  • invert_numlock change color when numlock off (for those who rely on numpad, like me)
  • bothlock_color when both conditions

by default color options are -1, which means ignore state
that's ok? or maybe add default colors but leave ability to set -1
i don't know how to handle this correctly in Home Manager, as not on Nix
should i just use

capslock_color = ${toString background.capslock_color}

and which type to set then?

now function looks way more cleanly and other stuff can be added easier

@bvr-yr bvr-yr marked this pull request as draft March 12, 2024 04:55
@bvr-yr bvr-yr marked this pull request as ready for review March 12, 2024 10:10
@bvr-yr
Copy link
Contributor Author

bvr-yr commented Mar 12, 2024

can you test a bit on multi-monitor? there been some issues with colors not being updated properly to the end on one of monitors, i think i fixed that but still kinda laggy a bit rarely with > 300ms transition, perhaps just my gpu sucks here

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vaxerski
Copy link
Member

for nix @fufexan

@fufexan
Copy link
Member

fufexan commented Mar 12, 2024

@bvr-yr added the nix options. If you feel the descriptions don't match well, feel free to change them.

@bvr-yr
Copy link
Contributor Author

bvr-yr commented Mar 12, 2024

nah that's good, thanks!

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

g

@vaxerski vaxerski merged commit f3a4116 into hyprwm:main Mar 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants