Input fade out timeout v2 #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the dots kind of fade into the placeholder text on a failure.
PaideiaDilemma
force-pushed
the
input-fade-out-timeout-v2
branch
from
d839714 to
5a62232
Compare
vaxerski
reviewed
Mar 6, 2024
| @@ -46,6 +46,7 @@ void CConfigManager::init() { | |||
| m_config.addConfigValue("general:hide_cursor", Hyprlang::INT{0}); | |||
| m_config.addConfigValue("general:grace", Hyprlang::INT{0}); | |||
| m_config.addConfigValue("general:no_fade_in", Hyprlang::INT{0}); | |||
| m_config.addConfigValue("general:input_empty_fade_timeout", Hyprlang::INT{1000}); | |||
There was a problem hiding this comment.
why isn't this in the input-field cat?
There was a problem hiding this comment.
idk because i used it in CHyprlock
wanted to change that anyways
|
|
Will close because probably overdone. Its simpler to just add it to CPasswordInputField::updateFade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successor to #109
The goal is to be able to show the placeholder text for a certain amount of time and then fade out the input field. That would allow to also handle the failure text better.
I felt like it was bad to add a timer within the renderer, as we have to acquire a lock for that.
That's why I added a virtual function to IWidget and implemented it for CPasswordInputField. This way we could implement it for CLabel as well and have some UI element fade together with the input field (don't know if anyone would want that).
Initiating the timer is done in onKey (to check if the password input was cleared) and in the onPasswordCheckTimer function (to add the timer when a auth failure happens).
Not ready to merge yet, would like some feedback first.